Issue 12320033: Merge 143437

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12320033: Merge 143437 (Closed)

Created:
7 years, 10 months ago by pfeldman

Modified:
7 years, 10 months ago

Reviewers:
pfeldman

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/

Visibility:
Public.

Merge 143437 > Web Inspector: View.markAsRoot should never be invoked on attached view. > https://bugs.webkit.org/show_bug.cgi?id=110224 > > Reviewed by Pavel Feldman. > > This will cause CSS loading problems after "show". > > * inspector/front-end/Drawer.js: > Ensure child view is detached before marked as root. > * inspector/front-end/View.js: > (WebInspector.View.prototype.markAsRoot): Added assertion. > TBR=eustas@chromium.org BUG=176912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143566

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/WebCore/inspector/front-end/Drawer.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/WebCore/inspector/front-end/View.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r143566.