Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 12320033: Merge 143437 (Closed)

Created:
7 years, 9 months ago by pfeldman
Modified:
7 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 143437 > Web Inspector: View.markAsRoot should never be invoked on attached view. > https://bugs.webkit.org/show_bug.cgi?id=110224 > > Reviewed by Pavel Feldman. > > This will cause CSS loading problems after "show". > > * inspector/front-end/Drawer.js: > Ensure child view is detached before marked as root. > * inspector/front-end/View.js: > (WebInspector.View.prototype.markAsRoot): Added assertion. > TBR=eustas@chromium.org BUG=176912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/WebCore/inspector/front-end/Drawer.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/View.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pfeldman
7 years, 9 months ago (2013-02-21 07:19:18 UTC) #1
pfeldman
7 years, 9 months ago (2013-02-21 07:19:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143566.

Powered by Google App Engine
This is Rietveld 408576698