LayoutTests/imported/web-platform-tests/html/editing/dnd/synthetic/001.html - Issue 1232003009: Implement DragEvent and move MouseEvent.dataTransfer

Side by Side Diff: LayoutTests/imported/web-platform-tests/html/editing/dnd/synthetic/001.html

Issue 1232003009: Implement DragEvent and move MouseEvent.dataTransfer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix failure of layouttest Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/events/script-tests/init-events.js ('k') | LayoutTests/imported/web-platform-tests/html/editing/dnd/synthetic/001-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Synthetic drag events</title>	4 <title>Synthetic drag events</title>

5 <script type="text/javascript" src="../../../../../../resources/ testharness.js"></script>	5 <script type="text/javascript" src="../../../../../../resources/ testharness.js"></script>

6 <script type="text/javascript" src="../../../../../../resources/ testharnessreport.js"></script>	6 <script type="text/javascript" src="../../../../../../resources/ testharnessreport.js"></script>

7 </head>	7 </head>

8 <body>	8 <body>

9 <div id="log"></div>	9 <div id="log"></div>

10 <script type="text/javascript">	10 <script type="text/javascript">

11 test(function() {	11 test(function() {

12 assert_own_property(window,'DragEvent');	12 assert_own_property(window,'DragEvent');

13 }, 'window.DragEvent should be exposed' );	13 }, 'window.DragEvent should be exposed' );

14 test(function() {	14 test(function() {
Rick Byers 2015/08/06 14:22:32 These "imported/web-platform-tests" are special, s These "imported/web-platform-tests" are special, see https://www.chromium.org/blink/importing-the-w3c-tests. I don't think we want to make edits to them here. The official home is here: https://github.com/w3c/web-platform-tests/commits/master/html/editing/dnd/syn.... I think it's fine to just update our expectations. Obviously we didn't exactly expect this test to pass before, and it still doesn't pass completely. Of course if you'd also like to contribute improvements to the test back to the w3c that's great too. But I wouldn't block this CL on it. Jimmy Jo 2015/08/07 02:42:03 Done. Show quoted text On 2015/08/06 14:22:32, Rick Byers wrote: > These "imported/web-platform-tests" are special, see > https://www.chromium.org/blink/importing-the-w3c-tests. I don't think we want > to make edits to them here. The official home is here: > https://github.com/w3c/web-platform-tests/commits/master/html/editing/dnd/syn.... > > I think it's fine to just update our expectations. Obviously we didn't exactly > expect this test to pass before, and it still doesn't pass completely. > > Of course if you'd also like to contribute improvements to the test back to the > w3c that's great too. But I wouldn't block this CL on it. Done.
15 assert_throws('NOT_SUPPORTED_ERR', function() {

16 var evt = document.createEvent('DragEvent');	15 var evt = document.createEvent('DragEvent');

17 });	16 }, 'createEvent should be able to create a DragEvent' );

18 }, 'createEvent should not be able to create a DragEvent' );

19 test(function() {	17 test(function() {

20 var evt = new DragEvent('dragstart');	18 var evt = new DragEvent('dragstart');

21 » assert_false( !!evt.initDragEvent, 'initDragEvent' );	19 » assert_true( !!evt.initDragEvent, 'initDragEvent' );

22 assert_true( !!evt.initMouseEvent, 'initMouseEvent' );	20 assert_true( !!evt.initMouseEvent, 'initMouseEvent' );

23 assert_true( !!evt.initUIEvent, 'initUIEvent' );	21 assert_true( !!evt.initUIEvent, 'initUIEvent' );

24 assert_true( !!evt.initEvent, 'initEvent' );	22 assert_true( !!evt.initEvent, 'initEvent' );

25 }, 'DragEvent should have all of the inherited init*Event methods' );	23 }, 'DragEvent should have all of the inherited init*Event methods' );

26	24

27 //cannot test non-synthetic dataTransfer objects as the param here because that needs a real DragEvent to create a proper one with global storage	25 //cannot test non-synthetic dataTransfer objects as the param here because that needs a real DragEvent to create a proper one with global storage

28 //will be tested in another file	26 //will be tested in another file

29 test(function() {	27 test(function() {

30 var evt = new DragEvent('dragstart');	28 var evt = new DragEvent('dragstart');

31 evt.initMouseEvent('dragstart', true, true, window, 1, 0, 0, 0, 0, false , false, false, false, 1, document.body);	29 evt.initMouseEvent('dragstart', true, true, window, 1, 0, 0, 0, 0, false , false, false, false, 1, document.body);

(...skipping 16 matching lines...) Expand all Loading...
48 test(function() {	46 test(function() {

49 var evt = new DragEvent('dragstart', {dataTransfer:undefined}), div = do cument.createElement('div'), ranlistener = false;	47 var evt = new DragEvent('dragstart', {dataTransfer:undefined}), div = do cument.createElement('div'), ranlistener = false;

50 div.ondragstart = function () { ranlistener = true; };	48 div.ondragstart = function () { ranlistener = true; };

51 div.dispatchEvent(evt);	49 div.dispatchEvent(evt);

52 assert_true(ranlistener);	50 assert_true(ranlistener);

53 }, 'DragEvent constructor with undefined as the dataTransfer parameter should be able to fire the event' );	51 }, 'DragEvent constructor with undefined as the dataTransfer parameter should be able to fire the event' );

54 test(function() {	52 test(function() {

55 assert_throws(new TypeError(), function() {	53 assert_throws(new TypeError(), function() {

56 var evt = new DragEvent('dragstart', {dataTransfer:{}});	54 var evt = new DragEvent('dragstart', {dataTransfer:{}});

57 });	55 });

58 }, 'DragEvent constructor with custom object as the dataTransfer parameter shoul d throw TypeError' );	56 }, 'DragEvent constructor with custom object as the dataTransfer parameter shoul d not throw TypeError' );

59 test(function() {	57 test(function() {

60 var evt = new DragEvent('dragstart'), div = document.createElement('div' ), ranlistener = false;	58 var evt = new DragEvent('dragstart'), div = document.createElement('div' ), ranlistener = false;

61 div.ondragstart = function () { ranlistener = true; };	59 div.ondragstart = function () { ranlistener = true; };

62 evt.initMouseEvent('dragstart', true, true, window, 1, 0, 0, 0, 0, false , false, false, false, 1, document.body);	60 evt.initMouseEvent('dragstart', true, true, window, 1, 0, 0, 0, 0, false , false, false, false, 1, document.body);

63 div.dispatchEvent(evt);	61 div.dispatchEvent(evt);

64 assert_true(ranlistener);	62 assert_true(ranlistener);

65 }, 'initMouseEvent should be able to fire the event' );	63 }, 'initMouseEvent should be able to fire the event' );

66 test(function() {	64 test(function() {

67 var evt = new DragEvent('dragstart'), div = document.createElement('div' ), ranlistener = false;	65 var evt = new DragEvent('dragstart'), div = document.createElement('div' ), ranlistener = false;

68 div.ondragstart = function () { ranlistener = true; };	66 div.ondragstart = function () { ranlistener = true; };

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
110 evt.initEvent('dragstart', true, true);	108 evt.initEvent('dragstart', true, true);

111 div.dispatchEvent(evt);	109 div.dispatchEvent(evt);

112 assert_equals(dTrans,null);	110 assert_equals(dTrans,null);

113 }, 'initEvent should give null as the dataTransfer' );	111 }, 'initEvent should give null as the dataTransfer' );

114	112

115 //cannot test that synthetic event does not use the same data store as non-synth etic event because that needs a real DragEvent to create a proper one with globa l storage	113 //cannot test that synthetic event does not use the same data store as non-synth etic event because that needs a real DragEvent to create a proper one with globa l storage

116 //will be tested in another file	114 //will be tested in another file

117 </script>	115 </script>

118 <noscript><p>Enable JavaScript and reload</p></noscript>	116 <noscript><p>Enable JavaScript and reload</p></noscript>

119 </body>	117 </body>

120 </html>	118 </html>

OLD	NEW