src/core/SkSharedMutex.cpp - Issue 1232003008: Fix undefined behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkSharedMutex.cpp

Issue 1232003008: Fix undefined behavior. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkSharedMutex.cpp

diff --git a/src/core/SkSharedMutex.cpp b/src/core/SkSharedMutex.cpp

index 3815ec3f2805162e165e744396313e0f15e19016..b9af10a2beb368e9564159bc2dfe1a1b4f4d163e 100644

--- a/src/core/SkSharedMutex.cpp

+++ b/src/core/SkSharedMutex.cpp

@@ -11,7 +11,6 @@

#include "SkSemaphore.h"

#include "SkTypes.h"

#if defined(THREAD_SANITIZER)

/* Report that a lock has been created at address "lock". */

@@ -168,7 +167,7 @@ void SkSharedMutex::releaseShared() {

ANNOTATE_RWLOCK_RELEASED(this, 0);

// Decrement the shared count.

- int32_t oldQueueCounts = fQueueCounts.fetch_add(-1 << kSharedOffset,

+ int32_t oldQueueCounts = fQueueCounts.fetch_add(~0U << kSharedOffset,

sk_memory_order_release);

// If shared count is going to zero (because the old count == 1) and there are exclusive

« no previous file with comments | « no previous file | no next file » | no next file with comments »