Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1232003005: Fix error in example for printing dates, clarify comments in general (Closed)

Created:
5 years, 5 months ago by Alan Knight
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/intl.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix error in example for printing dates, clarify comments in general BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/intl/commit/4b447813add9e085ec490d5c08f72cac7db8ec0b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -16 lines) Patch
M README.md View 1 1 chunk +20 lines, -5 lines 0 comments Download
M lib/src/intl/date_format.dart View 1 5 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Alan Knight
Improve Intl comments. See e.g. https://github.com/dart-lang/intl/issues/71 https://github.com/dart-lang/intl/issues/70 where people were confused about skeleton usage and ...
5 years, 5 months ago (2015-07-10 21:35:52 UTC) #2
kevmoo
Also: Are you going to update the version? At least to a -dev? https://codereview.chromium.org/1232003005/diff/1/README.md File ...
5 years, 5 months ago (2015-07-10 23:31:03 UTC) #3
Alan Knight
I'm not clear on the versioning conventions. I normally only update it when I'm intending ...
5 years, 5 months ago (2015-07-11 00:07:35 UTC) #4
kevmoo
Basically, it should ALWAYS be -dev except for the commit you actually deploy. Not a ...
5 years, 5 months ago (2015-07-11 00:08:31 UTC) #5
Alan Knight
5 years, 5 months ago (2015-07-11 00:12:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4b447813add9e085ec490d5c08f72cac7db8ec0b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698