Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 12320030: Revert 183709 (Closed)

Created:
7 years, 10 months ago by nhiroki
Modified:
7 years, 10 months ago
Reviewers:
sashab
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 183709 > Added unit tests for the Dart Chrome.* API wrappers, testing the Dart output mode from JSON Schema Compiler. > > The physical tests I've added are initial dummies - kalman, please take a look at the *structure* of the test setup. It feels like there is a lot of repetition of test names, but I like using python's unittest framework so it runs as a presubmit check. Any hints? > > I have a lot more tests I'd like to add. > > Note that there needs to be functionality to disable tests, e.g. there will need to be some tests that will fail from the IDL return value type bug (https://code.google.com/p/chromium/issues/detail?id=170837). > > Thanks, > > Sasha > > Review URL: https://chromiumcodereview.appspot.com/12218151 TBR=sashab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -787 lines) Patch
M tools/json_schema_compiler/compiler.py View 6 chunks +50 lines, -59 lines 0 comments Download
D tools/json_schema_compiler/dart_generator_test.py View 1 chunk +0 lines, -85 lines 0 comments Download
D tools/json_schema_compiler/dart_test/basic_event.dart View 1 chunk +0 lines, -40 lines 0 comments Download
D tools/json_schema_compiler/dart_test/basic_event.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools/json_schema_compiler/dart_test/basic_function.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tools/json_schema_compiler/dart_test/basic_function.idl View 1 chunk +0 lines, -13 lines 0 comments Download
D tools/json_schema_compiler/dart_test/basic_type.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D tools/json_schema_compiler/dart_test/basic_type.idl View 1 chunk +0 lines, -20 lines 0 comments Download
D tools/json_schema_compiler/dart_test/comments.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tools/json_schema_compiler/dart_test/comments.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D tools/json_schema_compiler/dart_test/complex_type.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D tools/json_schema_compiler/dart_test/complex_type.idl View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_namespace.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_namespace.idl View 1 chunk +0 lines, -6 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_type.dart View 1 chunk +0 lines, -37 lines 0 comments Download
D tools/json_schema_compiler/dart_test/empty_type.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/json_schema_compiler/dart_test/operatable_type.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tools/json_schema_compiler/dart_test/operatable_type.idl View 1 chunk +0 lines, -14 lines 0 comments Download
D tools/json_schema_compiler/dart_test/tags.dart View 1 chunk +0 lines, -116 lines 0 comments Download
D tools/json_schema_compiler/dart_test/tags.idl View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nhiroki
7 years, 10 months ago (2013-02-21 05:50:27 UTC) #1
nhiroki
7 years, 10 months ago (2013-02-21 05:50:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r183751.

Powered by Google App Engine
This is Rietveld 408576698