Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: runtime/vm/debugger.cc

Issue 12320023: Disabled context variables in local variable list in the debugger (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Return <unknown> for context variables now. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 18800)
+++ runtime/vm/debugger.cc (working copy)
@@ -493,6 +493,9 @@
if (var_info.kind == RawLocalVarDescriptors::kStackVar) {
*value = GetLocalVarValue(var_info.index);
} else {
+ // TODO(tball): enable context variables once problem with VariableAt() is
+ // fixed, where frame_ctx_level is sometimes off by 1 (issues 8593 and 8594)
+ /*
ASSERT(var_info.kind == RawLocalVarDescriptors::kContextVar);
ASSERT(!ctx_.IsNull());
// The context level at the PC/token index of this activation frame.
@@ -513,7 +516,8 @@
}
ASSERT(!ctx.IsNull());
*value = ctx.At(ctx_slot);
- }
+ } */
+ *value = String::New("<unknown>");
Ivan Posva 2013/02/21 01:26:12 Symbol::New("<unknown>")
Ivan Posva 2013/02/21 01:26:12 Symbol::New("<unknown>")
Tom Ball 2013/02/21 17:32:57 Done.
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698