Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 12320020: Merge 142755 (Closed)

Created:
7 years, 9 months ago by karen
Modified:
7 years, 9 months ago
Reviewers:
allan.jensen
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142755 > [Qt] window.open passes height and width parameters even if not defined in a page > https://bugs.webkit.org/show_bug.cgi?id=107705 > > Reviewed by Kenneth Rohde Christiansen. > > Source/WebCore: > > Do not override width or height of 0, as that indicates default size, and not minimum size. > > Tested by tst_qwebpage. > > * page/DOMWindow.cpp: > (WebCore::DOMWindow::adjustWindowRect): > > Source/WebKit/efl: > > Do not resize window when default size is requested. > > * WebCoreSupport/ChromeClientEfl.cpp: > (WebCore::ChromeClientEfl::setWindowRect): > > Source/WebKit/gtk: > > Do not resize window when default size is requested. > > * WebCoreSupport/ChromeClientGtk.cpp: > (WebKit::ChromeClient::setWindowRect): > > Source/WebKit/qt: > > Test that minimum size is applied only when the requested size is too small, > not when default is requested. > > * tests/qwebpage/tst_qwebpage.cpp: > (tst_QWebPage): > (TestPage): > (TestPage::TestPage): > (TestPage::createWindow): > (TestPage::slotGeometryChangeRequested): > (tst_QWebPage::openWindowDefaultSize): > TBR=allan.jensen@digia.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M Source/WebCore/page/DOMWindow.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp View 5 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
7 years, 9 months ago (2013-02-20 23:19:33 UTC) #1
karen
7 years, 9 months ago (2013-02-20 23:19:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143515.

Powered by Google App Engine
This is Rietveld 408576698