Issue 1231973006: CSSValue Immediates: Add move operators to CSSValue and NullableCSSValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231973006: CSSValue Immediates: Add move operators to CSSValue and NullableCSSValue (Closed)

Created:
5 years, 5 months ago by sashab

Modified:
5 years, 4 months ago

Reviewers:

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_1

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CSSValue Immediates: Add move operators to CSSValue and NullableCSSValue Add move operators (both constructors and operator= methods) to CSSPrimitiveValue in an attempt to reduce ref-churn. Although this is against the blink style guide, it was done as an experiment to see if performance-related issues were being caused from excessive copy operations. Depends on crrev.com/1164573002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
	M	Source/core/css/CSSValue.h	View	1	4 chunks	+30 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1164573002 Patch 770001

Issue 1231973006: CSSValue Immediates: Add move operators to CSSValue and NullableCSSValue (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #