Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/installer/setup/update_active_setup_version_work_item.h

Issue 1231973002: Force restoration of Chrome's shortcuts when Active Setup kicks in in response to a major OS upgrad… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a4_use_as_workitem
Patch Set: Move improvements to install_util_unittest.cc to a follow-up CL. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_ 5 #ifndef CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_
6 #define CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_ 6 #define CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "chrome/installer/util/set_reg_value_work_item.h" 10 #include "chrome/installer/util/set_reg_value_work_item.h"
11 #include "chrome/installer/util/work_item.h" 11 #include "chrome/installer/util/work_item.h"
12 12
13 // A WorkItem that updates (or installs if not present) the Active Setup 13 // A WorkItem that updates (or installs if not present) the Active Setup
14 // "Version" field in the registry. Optionally bumping the OS_UPGRADES component 14 // "Version" field in the registry. Optionally bumping the OS_UPGRADES component
15 // on demand. This WorkItem is only viable on machine-wide installs. 15 // on demand. This WorkItem is only viable on machine-wide installs.
16 class UpdateActiveSetupVersionWorkItem : public WorkItem { 16 class UpdateActiveSetupVersionWorkItem : public WorkItem {
17 public: 17 public:
18 // The components of the Active Setup Version entry, in order.
19 enum VersionComponent {
20 // The major version.
21 MAJOR,
22 // Unused component, always 0 for now.
23 UNUSED1,
24 // Number of OS upgrades handled since original install.
25 OS_UPGRADES,
26 // Unused component, always 0 for now.
27 UNUSED2,
28 };
29
18 // The operation to be performed by this UpdateActiveSetupVersionWorkItem. 30 // The operation to be performed by this UpdateActiveSetupVersionWorkItem.
19 enum Operation { 31 enum Operation {
20 // Update (or install if not present) the Active Setup "Version" in the 32 // Update (or install if not present) the Active Setup "Version" in the
21 // registry. 33 // registry.
22 UPDATE, 34 UPDATE,
23 // Also bump the OS_UPGRADES component on top of updating the version 35 // Also bump the OS_UPGRADES component on top of updating the version
24 // (will default to 1 if the version was absent or invalid). 36 // (will default to 1 if the version was absent or invalid).
25 UPDATE_AND_BUMP_OS_UPGRADES_COMPONENT, 37 UPDATE_AND_BUMP_OS_UPGRADES_COMPONENT,
26 }; 38 };
27 39
28 // Constructs an UpdateActiveSetupVersionWorkItem that will perform 40 // Constructs an UpdateActiveSetupVersionWorkItem that will perform
29 // |operation| on the |active_setup_path| key in the registry. This key needs 41 // |operation| on the |active_setup_path| key in the registry. This key needs
30 // to exist when this WorkItem is ran. 42 // to exist when this WorkItem is ran.
31 UpdateActiveSetupVersionWorkItem(const base::string16& active_setup_path, 43 UpdateActiveSetupVersionWorkItem(const base::string16& active_setup_path,
32 Operation operation); 44 Operation operation);
33 45
34 // Overriden from WorkItem. 46 // Overriden from WorkItem.
35 bool Do() override; 47 bool Do() override;
36 void Rollback() override; 48 void Rollback() override;
37 49
38 private: 50 private:
39 // The components of the Active Setup Version entry, in order.
40 enum ActiveSetupVersionComponent {
41 // The major version.
42 MAJOR,
43 // Unused component, always 0 for now.
44 UNUSED1,
45 // Number of OS upgrades handled since original install.
46 OS_UPGRADES,
47 // Unused component, always 0 for now.
48 UNUSED2,
49 };
50
51 // Returns the updated Active Setup version to be used based on the 51 // Returns the updated Active Setup version to be used based on the
52 // |existing_version|. 52 // |existing_version|.
53 base::string16 GetUpdatedActiveSetupVersion( 53 base::string16 GetUpdatedActiveSetupVersion(
54 const base::string16& existing_version); 54 const base::string16& existing_version);
55 55
56 // The underlying WorkItem re-used to operate forward and backward on the 56 // The underlying WorkItem re-used to operate forward and backward on the
57 // registry. 57 // registry.
58 SetRegValueWorkItem set_reg_value_work_item_; 58 SetRegValueWorkItem set_reg_value_work_item_;
59 59
60 // The Operation to be performed by this WorkItem when executed. 60 // The Operation to be performed by this WorkItem when executed.
61 const Operation operation_; 61 const Operation operation_;
62 62
63 DISALLOW_COPY_AND_ASSIGN(UpdateActiveSetupVersionWorkItem); 63 DISALLOW_COPY_AND_ASSIGN(UpdateActiveSetupVersionWorkItem);
64 }; 64 };
65 65
66 #endif // CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_ 66 #endif // CHROME_INSTALLER_SETUP_UPDATE_ACTIVE_SETUP_VERSION_WORK_ITEM_H_
OLDNEW
« no previous file with comments | « chrome/installer/setup/setup_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698