Issue 1231923006: Merge to M44: Fix an endless loop in CJBig2_HuffmanTable::parseFromCodedBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231923006: Merge to M44: Fix an endless loop in CJBig2_HuffmanTable::parseFromCodedBuffer (Closed)

Created:
5 years, 5 months ago by Lei Zhang

Modified:
5 years, 5 months ago

Reviewers:
brucedawson

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@2403

Target Ref:
refs/heads/chromium/2403

Visibility:
Public.

Merge to M44: Fix an endless loop in CJBig2_HuffmanTable::parseFromCodedBuffer This issue is trigged by the conversion from unsigned int to signed int. A large unsigned int is converted to int. It's represented as a negative int which is used in the condition of while later. BUG=482639 R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1146913003 (cherry picked from commit bc4b82ea7a9c6603c6a1c89e00f4e6381c1b6804) Committed: https://pdfium.googlesource.com/pdfium/+/90805aa3cb40414f4eecce7d16b4dc66153dd49c

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp	View		5 chunks	+11 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as 90805aa3cb40414f4eecce7d16b4dc66153dd49c (presubmit successful).

5 years, 5 months ago (2015-07-13 21:25:06 UTC) #2

Message was sent while issue was closed.

lgtm