Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 12319150: remove all global associative maps for fontconfig host (Closed)

Created:
7 years, 9 months ago by reed1
Modified:
7 years, 9 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

use fontconfig fonthost for skia (in prep for using in chrome) Committed: https://code.google.com/p/skia/source/detail?r=7887

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -341 lines) Patch
M trunk/gyp/ports.gyp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M trunk/include/ports/SkFontConfigInterface.h View 1 chunk +25 lines, -14 lines 0 comments Download
M trunk/src/ports/SkFontConfigInterface_direct.cpp View 7 chunks +34 lines, -158 lines 0 comments Download
M trunk/src/ports/SkFontHost_fontconfig.cpp View 1 2 3 7 chunks +116 lines, -168 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years, 9 months ago (2013-02-27 17:23:48 UTC) #1
bungeman-skia
lgtm
7 years, 9 months ago (2013-02-27 18:03:15 UTC) #2
reed1
7 years, 9 months ago (2013-02-27 19:06:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r7887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698