chromeos/network/onc/onc_translator_shill_to_onc.cc - Issue 12319145: Using the new Network*Handlers in networkingPrivate Extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translator_shill_to_onc.cc

Issue 12319145: Using the new Network*Handlers in networkingPrivate Extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial patch. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translator_shill_to_onc.cc

diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc

index b91ac66142a3d5f7b65f7892844f929f27a4ee03..3b06661b7fa535b5237dc3d80a9ead3bc37f2d21 100644

--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc

+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc

@@ -202,6 +202,8 @@ void ShillToONCTranslator::TranslateAndAddNestedObject(

*field_signature->value_signature);

scoped_ptr<base::DictionaryValue> nested_object =

nested_translator.CreateTranslatedONCObject();

+ if (nested_object->empty())

+ return;

onc_object_->SetWithoutPathExpansion(onc_field_name, nested_object.release());

}