Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5601)

Unified Diff: chrome/browser/chromeos/extensions/networking_private_api.h

Issue 12319145: Using the new Network*Handlers in networkingPrivate Extension API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/networking_private_api.h
diff --git a/chrome/browser/chromeos/extensions/networking_private_api.h b/chrome/browser/chromeos/extensions/networking_private_api.h
index 176627715d5320cc740cfd32fecabee93fc31798..84af1f69683817e23979d079f9a6f165bccb12bf 100644
--- a/chrome/browser/chromeos/extensions/networking_private_api.h
+++ b/chrome/browser/chromeos/extensions/networking_private_api.h
@@ -47,7 +47,7 @@ class NetworkingPrivateGetPropertiesFunction : public AsyncExtensionFunction {
// Implements the chrome.networkingPrivate.getVisibleNetworks method.
class NetworkingPrivateGetVisibleNetworksFunction
- : public AsyncExtensionFunction {
+ : public SyncExtensionFunction {
public:
NetworkingPrivateGetVisibleNetworksFunction() {}
DECLARE_EXTENSION_FUNCTION("networkingPrivate.getVisibleNetworks",
@@ -56,15 +56,10 @@ class NetworkingPrivateGetVisibleNetworksFunction
protected:
virtual ~NetworkingPrivateGetVisibleNetworksFunction();
- // AsyncExtensionFunction overrides.
+ // SyncExtensionFunction overrides.
virtual bool RunImpl() OVERRIDE;
- // Gets called when all the results are in.
- void SendResultCallback(const std::string& error,
- scoped_ptr<base::ListValue> result_list);
-
private:
-
DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateGetVisibleNetworksFunction);
};
@@ -86,8 +81,9 @@ class NetworkingPrivateStartConnectFunction : public AsyncExtensionFunction {
// itself succeeded, just that the request did.
void ConnectionStartSuccess();
- void ConnectionStartFailed(const std::string& error_name,
- const std::string& error_message);
+ void ConnectionStartFailed(
+ const std::string& error_name,
+ const scoped_ptr<base::DictionaryValue> error_data);
DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateStartConnectFunction);
};
@@ -111,8 +107,9 @@ class NetworkingPrivateStartDisconnectFunction
// disconnect itself succeeded, just that the request did.
void DisconnectionStartSuccess();
- void DisconnectionStartFailed(const std::string& error_name,
- const std::string& error_message);
+ void DisconnectionStartFailed(
+ const std::string& error_name,
+ const scoped_ptr<base::DictionaryValue> error_data);
DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateStartDisconnectFunction);
};

Powered by Google App Engine
This is Rietveld 408576698