Using the new Network*Handlers in networkingPrivate Extension API.

chromeos/network/network_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
 #include "chromeos/network/managed_state.h"
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace chromeos {
 
 // Simple class to provide network state information about a network service.
 // This class should always be passed as a const* and should never be held
 // on to. Store network_state->path() (defined in ManagedState) instead and
 // call NetworkStateHandler::GetNetworkState(path) to retrieve the state for
 // the network.
 class CHROMEOS_EXPORT NetworkState : public ManagedState {
  public:
   explicit NetworkState(const std::string& path);
   virtual ~NetworkState();
 
-  // ManagedState overrides
+  // ManagedState overrides.
+  // If you change this method, update GetProperties too.

[stevenjb, 2013/03/07 18:29:54]

nit: We should probably describe this function too (my bad)
Also, technically non-sentences like "ManagedState overrides", "// Accessors",
and the other comments below should not end with a '.'

[pneubeck (no reviews), 2013/03/07 19:26:36]

This function is already documented in the base class. I don't think we want to
repeat the description? This comment is only implementation related.

I'm rather passionless about the comments format. I think, I looked at
http://src.chromium.org/viewvc/chrome/trunk/src/chromeos/network/network_stat...
for consistency, but that in turn was influenced by our last review ;-)

On 2013/03/07 18:29:54, stevenjb (chromium) wrote:

   virtual bool PropertyChanged(const std::string& key,
                                const base::Value& value) OVERRIDE;
 
-  // Accessors
+  // Fills |dictionary| with the state properties. All the properties that are
+  // accepted by PropertyChanged are stored in |dictionary|, no other values are
+  // stored.
+  void GetProperties(base::DictionaryValue* dictionary) const;
+
+  // Accessors.
   const std::string& security() const { return security_; }
   const std::string& ip_address() const { return ip_address_; }
   const std::string& device_path() const { return device_path_; }
   const std::string& guid() const { return guid_; }
   const std::string& connection_state() const { return connection_state_; }
   const std::string& error() const { return error_; }
-  // Wireless property accessors
+  // Wireless property accessors.
   int signal_strength() const { return signal_strength_; }
-  // Cellular property accessors
+  // Cellular property accessors.
   const std::string& technology() const { return technology_; }
   const std::string& activation_state() const { return activation_state_; }
   const std::string& roaming() const { return roaming_; }
 
   bool IsConnectedState() const;
   bool IsConnectingState() const;
 
-  // Helpers (used e.g. when a state is cached)
+  // Helpers (used e.g. when a state is cached).
   static bool StateIsConnected(const std::string& connection_state);
   static bool StateIsConnecting(const std::string& connection_state);
 
  private:
   friend class NetworkStateHandler;
   friend class NetworkChangeNotifierChromeosUpdateTest;
 
   // Called by NetworkStateHandler when the ip config changes.
   void set_ip_address(const std::string& ip_address) {
     ip_address_ = ip_address;
   }
 
-  // Common Network Service properties
+  // Common Network Service properties.
   std::string security_;
   std::string device_path_;
   std::string guid_;
   std::string ip_address_;
   std::string connection_state_;
   std::string error_;
-  // Wireless properties
+  // Wireless properties.
   int signal_strength_;
-  // Cellular properties
+  // Cellular properties.
   std::string technology_;
   std::string activation_state_;
   std::string roaming_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_H_