Using the new Network*Handlers in networkingPrivate Extension API.

chromeos/network/network_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
+#include "base/memory/scoped_ptr.h"
 #include "chromeos/network/managed_state.h"
 
+namespace base {
+class DictionaryValue;
+}
+
 namespace chromeos {
 
 // Simple class to provide network state information about a network service.
 // This class should always be passed as a const* and should never be held
 // on to. Store network_state->path() (defined in ManagedState) instead and
 // call NetworkStateHandler::GetNetworkState(path) to retrieve the state for
 // the network.
 class CHROMEOS_EXPORT NetworkState : public ManagedState {
  public:
   explicit NetworkState(const std::string& path);
@@ skipping 13 matching lines @@
   // Wireless property accessors
   int signal_strength() const { return signal_strength_; }
   // Cellular property accessors
   const std::string& technology() const { return technology_; }
   const std::string& activation_state() const { return activation_state_; }
   const std::string& roaming() const { return roaming_; }
 
   bool IsConnectedState() const;
   bool IsConnectingState() const;
 
+  scoped_ptr<base::DictionaryValue> TranslateToONC() const;

[stevenjb, 2013/03/04 18:57:58]

I don't like having this here. I would rather we have a namespaced global
method:

bool onc::TranslateNetworkState(const NetworkState*, DictionaryValue* onc)

(note: I also prefer passing the dictionary to fill in rather than passing
around scoped_ptr, but that's just a personal style preference).

If we don't have and don't want NetworkState dependencies in the ONC code
itself, I am fine with adding network_state_onc.cc to this directory, but I
don't want NetworkState itself to depend on ONC. Does that make sense?

[pneubeck (no reviews), 2013/03/05 13:11:55]

Done.

+
   // Helpers (used e.g. when a state is cached)
   static bool StateIsConnected(const std::string& connection_state);
   static bool StateIsConnecting(const std::string& connection_state);
 
  private:
   friend class NetworkStateHandler;
   friend class NetworkChangeNotifierChromeosUpdateTest;
 
   // Called by NetworkStateHandler when the ip config changes.
   void set_ip_address(const std::string& ip_address) {
@@ skipping 13 matching lines @@
   std::string technology_;
   std::string activation_state_;
   std::string roaming_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_H_