src/hydrogen.cc - Issue 12319144: Avoid TLS accesses in Object::Lookup and Object::GetPrototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 12319144: Avoid TLS accesses in Object::Lookup and Object::GetPrototype. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Simplified Object::GetPrototype a bit Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 73287f417344995ba72dd17c92556ad1d87b08d7..ae940841680622d5531a972af483859610348780 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5989,8 +5989,10 @@ HInstruction* HOptimizedGraphBuilder::BuildStoreNamedField(

proto = proto_result.holder();

} else {

// Otherwise, find the top prototype.

- while (proto->GetPrototype()->IsJSObject()) proto = proto->GetPrototype();

- ASSERT(proto->GetPrototype()->IsNull());

+ while (proto->GetPrototype(isolate())->IsJSObject()) {

+ proto = proto->GetPrototype(isolate());

+ }

+ ASSERT(proto->GetPrototype(isolate())->IsNull());

}

ASSERT(proto->IsJSObject());

AddInstruction(new(zone()) HCheckPrototypeMaps(

« no previous file with comments | « src/handles.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »