src/handles.cc - Issue 12319144: Avoid TLS accesses in Object::Lookup and Object::GetPrototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.cc

Issue 12319144: Avoid TLS accesses in Object::Lookup and Object::GetPrototype. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Simplified Object::GetPrototype a bit Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/handles.cc

diff --git a/src/handles.cc b/src/handles.cc

index 94293341c577af45cd952c537dfcbfc234fe82b4..5de9b6c340a26fa80ec0d7b3c63090b895f50585 100644

--- a/src/handles.cc

+++ b/src/handles.cc

@@ -647,7 +647,7 @@ Handle<FixedArray> GetKeysInFixedArrayFor(Handle<JSReceiver> object,

// Only collect keys if access is permitted.

for (Handle<Object> p = object;

*p != isolate->heap()->null_value();

- p = Handle<Object>(p->GetPrototype(), isolate)) {

+ p = Handle<Object>(p->GetPrototype(isolate), isolate)) {

if (p->IsJSProxy()) {

Handle<JSProxy> proxy(JSProxy::cast(*p), isolate);

Handle<Object> args[] = { proxy };

« no previous file with comments | « src/builtins.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »