Issue 12319144: Avoid TLS accesses in Object::Lookup and Object::GetPrototype.

Issue 12319144: Avoid TLS accesses in Object::Lookup and Object::GetPrototype. (Closed)

Created:
7 years, 9 months ago by Sven Panne

Modified:
7 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Avoid TLS accesses in Object::Lookup and Object::GetPrototype. Both methods were among the top causes for TLS accesses. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13759

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -120 lines)			Patch
M	src/accessors.cc	View		11 chunks	+27 lines, -21 lines	0 comments	Download
M	src/api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1	5 chunks	+9 lines, -7 lines	0 comments	Download
M	src/builtins.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	5 chunks	+9 lines, -7 lines	0 comments	Download
M	src/ic.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/ic-inl.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/isolate.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	1	5 chunks	+9 lines, -7 lines	0 comments	Download
M	src/objects.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	1 2	13 chunks	+37 lines, -31 lines	0 comments	Download
M	src/property.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1	7 chunks	+8 lines, -7 lines	0 comments	Download
M	src/string-stream.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/stub-cache.cc	View	1	14 chunks	+28 lines, -14 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	5 chunks	+9 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

ulan

LGTM if the comment is addressed. Looks like before this CL, GetPrototype would call Isolate::Current() ...

7 years, 9 months ago (2013-02-27 13:19:14 UTC) #2

Sven Panne

7 years, 9 months ago (2013-02-27 13:22:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r13759 (presubmit successful).