Update extensions with Drag-and-Drop in extension settings page.

chrome/browser/extensions/crx_installer.cc

Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index f997fc6fb78ab8869ba650c64851d3f9ff73df52..ed3d3cb3f3758531d6c33099f9330d620f2ac337 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -41,6 +41,7 @@
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/feature_switch.h"
+#include "chrome/common/extensions/permissions/permission_set.h"

[Joe Thomas, 2013/02/27 20:55:39]

This is not required.

 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/resource_dispatcher_host.h"
@@ -108,7 +109,8 @@ CrxInstaller::CrxInstaller(
       error_on_unsupported_requirements_(false),
       requirements_checker_(new extensions::RequirementsChecker()),
       has_requirement_errors_(false),
-      install_wait_for_idle_(true) {
+      install_wait_for_idle_(true),
+      update_from_settings_page_(false) {
   installer_task_runner_ = frontend_weak->GetFileTaskRunner();
   if (!approval)
     return;
@@ -428,6 +430,10 @@ void CrxInstaller::ConfirmInstall() {
   if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
     return;
 
+  // Check whether this install is initiated from the settings page to
+  // update an existing extension or app.
+  CheckUpdateFromSettingsPage();
+
   string16 error;
   if (!ExtensionSystem::Get(profile_)->management_policy()->
       UserMayLoad(extension_, &error)) {
@@ -452,7 +458,9 @@ void CrxInstaller::ConfirmInstall() {
   current_version_ =
       frontend_weak_->extension_prefs()->GetVersionString(extension_->id());
 
-  if (client_ && (!allow_silent_install_ || !approved_)) {
+  if (client_ &&
+      (!allow_silent_install_ || !approved_) &&
+      !update_from_settings_page_) {
     AddRef();  // Balanced in Proceed() and Abort().
     client_->ConfirmInstall(this, extension_.get(), show_dialog_callback_);
   } else {
@@ -465,31 +473,43 @@ void CrxInstaller::ConfirmInstall() {
 }
 
 void CrxInstaller::InstallUIProceed() {
-  if (!installer_task_runner_->PostTask(
-          FROM_HERE,
-          base::Bind(&CrxInstaller::CompleteInstall, this)))
-    NOTREACHED();
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
-  Release();  // balanced in ConfirmInstall().
-}
+  if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
+    return;
 
-void CrxInstaller::InstallUIAbort(bool user_initiated) {
-  std::string histogram_name = user_initiated ?
-      "Extensions.Permissions_InstallCancel" :
-      "Extensions.Permissions_InstallAbort";
-  ExtensionService::RecordPermissionMessagesHistogram(
-      extension_, histogram_name.c_str());
+  if (update_from_settings_page_) {

[Matt Perry, 2013/02/28 01:13:27]

could you add a comment here that explains we're getting this in response to
ConfirmReEnable? I was confused at first.

[Joe Thomas, 2013/02/28 02:01:16]

Done.

+    frontend_weak_->GrantPermissionsAndEnableExtension(
+        extension_.get(), client_->record_oauth2_grant());
+  } else {
+    if (!installer_task_runner_->PostTask(
+            FROM_HERE,
+            base::Bind(&CrxInstaller::CompleteInstall, this)))
+      NOTREACHED();
+  }
 
-  // Kill the theme loading bubble.
-  content::NotificationService* service =
-      content::NotificationService::current();
-  service->Notify(chrome::NOTIFICATION_NO_THEME_DETECTED,
-                  content::Source<CrxInstaller>(this),
-                  content::NotificationService::NoDetails());
+  Release();  // balanced in ConfirmInstall() or ConfirmReEnable().
+}
 
-  NotifyCrxInstallComplete(false);
+void CrxInstaller::InstallUIAbort(bool user_initiated) {
+  if (!update_from_settings_page_) {
+    std::string histogram_name = user_initiated ?
+        "Extensions.Permissions_InstallCancel" :
+        "Extensions.Permissions_InstallAbort";
+    ExtensionService::RecordPermissionMessagesHistogram(
+        extension_, histogram_name.c_str());
+
+    // Kill the theme loading bubble.
+    content::NotificationService* service =
+        content::NotificationService::current();
+    service->Notify(chrome::NOTIFICATION_NO_THEME_DETECTED,
+                    content::Source<CrxInstaller>(this),
+                    content::NotificationService::NoDetails());
+
+    NotifyCrxInstallComplete(false);
+  }
 
-  Release();  // balanced in ConfirmInstall().
+  Release();  // balanced in ConfirmInstall() or ConfirmReEnable().
 
   // We're done. Since we don't post any more tasks to ourself, our ref count
   // should go to zero and we die. The destructor will clean up the temp dir.
@@ -611,20 +631,21 @@ void CrxInstaller::ReportSuccessFromUIThread() {
   if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
     return;
 
-  // If there is a client, tell the client about installation.
-  if (client_) {
-    client_->OnInstallSuccess(extension_.get(), install_icon_.get());
-  }
+  if (!update_from_settings_page_) {
+    // If there is a client, tell the client about installation.
+    if (client_)
+      client_->OnInstallSuccess(extension_.get(), install_icon_.get());
 
-  if (client_ && !approved_)
+    if (client_ && !approved_)
     record_oauth2_grant_ = client_->record_oauth2_grant();

[Matt Perry, 2013/02/28 01:13:27]

indent

[Joe Thomas, 2013/02/28 02:01:16]

Done.

 
-  // We update the extension's granted permissions if the user already approved
-  // the install (client_ is non NULL), or we are allowed to install this
-  // silently.
-  if (client_ || allow_silent_install_) {
-    PermissionsUpdater perms_updater(profile());
-    perms_updater.GrantActivePermissions(extension_, record_oauth2_grant_);
+    // We update the extension's granted permissions if the user already
+    // approved the install (client_ is non NULL), or we are allowed to install
+    // this silently.
+    if (client_ || allow_silent_install_) {
+      PermissionsUpdater perms_updater(profile());
+      perms_updater.GrantActivePermissions(extension_, record_oauth2_grant_);
+    }
   }
 
   // Install the extension if it's not blacklisted, but notify either way.
@@ -674,9 +695,9 @@ void CrxInstaller::NotifyCrxInstallComplete(bool success) {
       content::Source<CrxInstaller>(this),
       content::Details<const Extension>(success ? extension_.get() : NULL));
 
-  // We're done. We don't post any more tasks to ourselves so we are deleted
-  // soon.
-  extension_ = NULL;

[Matt Perry, 2013/02/28 01:13:27]

Don't delete this code. You should still NULL-out extension_ if we don't end up
calling client_->ConfirmReEnable

[Joe Thomas, 2013/02/28 02:01:16]

This code is not required. If we dont call client_->ConfirmReEnable,
CrxInstaller object's lifetime ends and it gets destroyed. Here extension_ is
nothing but scoped_refptr<Extension>. And scoped_refptr's destructor does the
same as assigning the variable to NULL (it calls Release() on the object it
hold).

[Matt Perry, 2013/02/28 20:02:08]

OK

+  if (success)
+    ConfirmReEnable();
+
 }
 
 void CrxInstaller::CleanupTempFiles() {
@@ -701,4 +722,43 @@ void CrxInstaller::CleanupTempFiles() {
   }
 }
 
+void CrxInstaller::CheckUpdateFromSettingsPage() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
+    return;
+
+  if (off_store_install_allow_reason_ != OffStoreInstallAllowedFromSettingsPage)
+    return;
+
+  const Extension* installed_extension =
+      frontend_weak_->GetInstalledExtension(extension_->id());
+  if (installed_extension) {
+    // Previous version of the extension exists.
+    update_from_settings_page_ = true;
+    expected_id_ = installed_extension->id();
+    install_source_ = installed_extension->location();
+    install_cause_ = extension_misc::INSTALL_CAUSE_UPDATE;
+  }
+}
+
+void CrxInstaller::ConfirmReEnable() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
+    return;
+
+  if (!update_from_settings_page_)
+    return;
+
+  extensions::ExtensionPrefs* prefs = frontend_weak_->extension_prefs();
+  if (!prefs->DidExtensionEscalatePermissions(extension_->id()))
+    return;
+
+  if (client_) {
+    AddRef();  // Balanced in Proceed() and Abort().

[Matt Perry, 2013/02/28 01:13:27]

nit: balanced in InstallUIProceed* ...

[Joe Thomas, 2013/02/28 02:01:16]

Done.

+    client_->ConfirmReEnable(this, extension_.get());
+  }
+}
+
 }  // namespace extensions