Update extensions with Drag-and-Drop in extension settings page.

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 23 matching lines @@
 #include "chrome/browser/extensions/webstore_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/feature_switch.h"
+#include "chrome/common/extensions/permissions/permission_set.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/browser/user_metrics.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 47 matching lines @@
       allow_silent_install_(false),
       bypass_blacklist_for_test_(false),
       install_cause_(extension_misc::INSTALL_CAUSE_UNSET),
       creation_flags_(Extension::NO_FLAGS),
       off_store_install_allow_reason_(OffStoreInstallDisallowed),
       did_handle_successfully_(true),
       record_oauth2_grant_(false),
       error_on_unsupported_requirements_(false),
       requirements_checker_(new extensions::RequirementsChecker()),
       has_requirement_errors_(false),
-      install_wait_for_idle_(true) {
+      install_wait_for_idle_(true),
+      show_update_prompt_(false) {
   installer_task_runner_ = frontend_weak->GetFileTaskRunner();
   if (!approval)
     return;
 
   CHECK(profile_->IsSameProfile(approval->profile));
   if (client_) {
     client_->install_ui()->SetUseAppInstalledBubble(
         approval->use_app_installed_bubble);
     client_->install_ui()->SetSkipPostInstallUI(approval->skip_post_install_ui);
   }
@@ skipping 299 matching lines @@
   }
 
   ConfirmInstall();
 }
 
 void CrxInstaller::ConfirmInstall() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
     return;
 
+  // Limit the extension update with update-prompt only to the updates
+  // initiated from the extension settings page.
+  if (client_ &&
+      off_store_install_allow_reason_ ==
+          OffStoreInstallAllowedFromSettingsPage)
+    CheckExtensionExistsAlready(extension_.get());
+
   string16 error;
   if (!ExtensionSystem::Get(profile_)->management_policy()->
       UserMayLoad(extension_, &error)) {
     ReportFailureFromUIThread(CrxInstallerError(error));
     return;
   }
 
   GURL overlapping_url;
   const Extension* overlapping_extension =
       frontend_weak_->extensions()->
       GetHostedAppByOverlappingWebExtent(extension_->web_extent());
   if (overlapping_extension &&
       overlapping_extension->id() != extension_->id()) {
     ReportFailureFromUIThread(
         CrxInstallerError(
             l10n_util::GetStringFUTF16(
                 IDS_EXTENSION_OVERLAPPING_WEB_EXTENT,
                 UTF8ToUTF16(overlapping_extension->name()))));
     return;
   }
 
   current_version_ =
       frontend_weak_->extension_prefs()->GetVersionString(extension_->id());
 
   if (client_ && (!allow_silent_install_ || !approved_)) {
     AddRef();  // Balanced in Proceed() and Abort().
-    client_->ConfirmInstall(this, extension_.get(), show_dialog_callback_);
+    if (show_update_prompt_)
+      client_->ConfirmUpdate(this, extension_.get());
+    else
+      client_->ConfirmInstall(this, extension_.get(), show_dialog_callback_);
   } else {
     if (!installer_task_runner_->PostTask(
             FROM_HERE,
             base::Bind(&CrxInstaller::CompleteInstall, this)))
       NOTREACHED();
   }
   return;
 }
 
 void CrxInstaller::InstallUIProceed() {
@@ skipping 226 matching lines @@
     extension_file_util::DeleteFile(temp_dir_, true);
     temp_dir_ = base::FilePath();
   }
 
   if (delete_source_ && !source_file_.value().empty()) {
     extension_file_util::DeleteFile(source_file_, false);
     source_file_ = base::FilePath();
   }
 }
 
+void CrxInstaller::CheckExtensionExistsAlready(const Extension* extension) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  if (!frontend_weak_.get() || frontend_weak_->browser_terminating())
+    return;
+
+  const Extension* installed_extension =
+      frontend_weak_->GetInstalledExtension(extension->id());
+  if (installed_extension) {
+    // Previous version of the extension exists.
+    expected_id_ = installed_extension->id();
+    install_source_ = installed_extension->location();
+    install_cause_ = extension_misc::INSTALL_CAUSE_UPDATE;
+
+    // Update prompt is shown only if the extension has requested for
+    // additional permissions.
+    scoped_refptr<PermissionSet> granted_permissions =
+        frontend_weak_->extension_prefs()->GetGrantedPermissions(
+            installed_extension->id());
+    CHECK(granted_permissions.get());
+    show_update_prompt_ = granted_permissions->HasLessPrivilegesThan(
+        extension->GetActivePermissions());
+    if (!show_update_prompt_) {
+      allow_silent_install_ = true;
+      approved_ = true;
+    }
+
+    // Suppress the UI after success or failure.
+    client_->install_ui()->SetSkipPostInstallUI(true);
+  }
+}
+
 }  // namespace extensions