|
|
Fix layering violation in content\browser\renderer_host. That directory shouldn't be including web_contents.
It looks like this regressed because we forgot to update the DEPS exclusion after the tab_contents->web_contents rename. I've fixed the non test case, added exclusion for tests, and put a temporary workaround for the media subdirectory.
It seems that the media subdirectory should move to content\browser since it has dependencies on web_contents.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184735
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+95 lines, -73 lines) |
Patch |
 |
M |
chrome/browser/chrome_browser_main.h
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chrome_browser_main.cc
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/three_d_api_observer.h
|
View
|
|
1 chunk |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/three_d_api_observer.cc
|
View
|
|
2 chunks |
+14 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_tab_contents.cc
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/browser_plugin/browser_plugin_guest.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/browser_plugin/browser_plugin_guest.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/gpu/gpu_data_manager_impl.h
|
View
|
|
3 chunks |
+10 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/gpu/gpu_data_manager_impl.cc
|
View
|
|
3 chunks |
+24 lines, -3 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/DEPS
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/media/DEPS
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_message_filter.cc
|
View
|
|
3 chunks |
+2 lines, -28 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/render_widget_host_view_guest.cc
|
View
|
|
2 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/test_render_view_host.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/browser/web_contents/web_contents_impl.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
content/public/browser/gpu_data_manager.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/public/browser/gpu_data_manager_observer.h
|
View
|
|
2 chunks |
+12 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/browser/web_contents_observer.h
|
View
|
|
2 chunks |
+0 lines, -7 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
12319119:
Fix layering violation in content\browser\renderer_host. That directory shouldn't be including web_… (Closed)
