content/browser/devtools/render_view_devtools_agent_host.h - Issue 12319114: Extract debugger target enumeration into a separate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_view_devtools_agent_host.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger

Patch Set: Fixed compile Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/devtools_http_handler_impl.cc ('K') | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | content/public/browser/devtools_target_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/render_view_devtools_agent_host.h

diff --git a/content/browser/devtools/render_view_devtools_agent_host.h b/content/browser/devtools/render_view_devtools_agent_host.h

index 30571868ec00182a729a956c7c297536a9867d91..1a847a647898c630aac27ec0074fd06493eedf75 100644

--- a/content/browser/devtools/render_view_devtools_agent_host.h

+++ b/content/browser/devtools/render_view_devtools_agent_host.h

@@ -18,6 +18,7 @@

namespace content {

class DevToolsAgentHostRvhObserver;

+class NavigationEntry;

pfeldman 2013/03/05 12:06:41 You don't seem to need this.

Vladislav Kaznacheev 2013/03/05 13:35:44 Done.

class RendererOverridesHandler;

class RenderViewHost;

@@ -41,6 +42,12 @@ class CONTENT_EXPORT RenderViewDevToolsAgentHost

// DevTooolsAgentHost overrides.

virtual RenderViewHost* GetRenderViewHost() OVERRIDE;

+ virtual std::string GetTitle() OVERRIDE;

+ virtual GURL GetUrl() OVERRIDE;

+ virtual GURL GetFaviconUrl() OVERRIDE;

// DevToolsAgentHostImpl overrides.

virtual void DispatchOnInspectorBackend(const std::string& message) OVERRIDE;

virtual void SendMessageToAgent(IPC::Message* msg) OVERRIDE;