Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: content/public/browser/devtools_agent_host.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Fixed thumbnail url generation, added a test Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_agent_host.h
diff --git a/content/public/browser/devtools_agent_host.h b/content/public/browser/devtools_agent_host.h
index 533c31df79f1545ef84ab2f450590b77339aa4a0..a056645300a9c7a38e10f2e0cf4e8dc9a69ba1a7 100644
--- a/content/public/browser/devtools_agent_host.h
+++ b/content/public/browser/devtools_agent_host.h
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/memory/ref_counted.h"
#include "content/common/content_export.h"
+#include "googleurl/src/gurl.h"
namespace content {
@@ -35,16 +36,33 @@ class CONTENT_EXPORT DevToolsAgentHost
static bool IsDebuggerAttached(WebContents* web_contents);
+ static const std::string EmptyCookie;
+
// Detaches given |rvh| from the agent host temporarily and returns a cookie
- // that allows to reattach another rvh to that agen thost later. Returns -1 if
- // there is no agent host associated with the |rvh|.
- static int DisconnectRenderViewHost(RenderViewHost* rvh);
+ // that allows to reattach another rvh to that agen thost later.
+ // ReturnsEmptyCookie if there is no agent host associated with the |rvh|.
+ static std::string DisconnectRenderViewHost(RenderViewHost* rvh);
// Reattaches agent host detached with DisconnectRenderViewHost method above
// to |rvh|.
- static void ConnectRenderViewHost(int agent_host_cookie,
+ static void ConnectRenderViewHost(const std::string& agent_host_cookie,
RenderViewHost* rvh);
+ // Returns the unique id of the agent.
+ virtual std::string id() = 0;
+
+ // Returns the page title.
+ virtual std::string title() = 0;
+
+ // Returns the page url.
+ virtual GURL url() = 0;
+
+ // Returns thumbnail url for the page.
+ virtual GURL thumbnail_url() = 0;
+
+ // Returns favicon url for the page.
+ virtual GURL favicon_url() = 0;
+
// Returns render view host instance for this host if any.
virtual RenderViewHost* GetRenderViewHost() = 0;

Powered by Google App Engine
This is Rietveld 408576698