chrome/browser/extensions/extension_service.cc - Issue 12319114: Extract debugger target enumeration into a separate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger

Patch Set: Fixed thumbnail url generation, added a test Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/chrome_tests.gypi » ('j') | chrome/test/data/extensions/api_test/debugger_remote/background.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 301bcd7aaf8d9893766c9a227cae7e90f8255488..25fae9f7ac206c44e5534dc61670225287c6892b 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -730,9 +730,9 @@ void ExtensionService::ReloadExtensionWithEvents(

manager->GetBackgroundHostForExtension(extension_id);

if (host && DevToolsAgentHost::HasFor(host->render_view_host())) {

// Look for an open inspector for the background page.

- int devtools_cookie = DevToolsAgentHost::DisconnectRenderViewHost(

+ std::string devtools_cookie = DevToolsAgentHost::DisconnectRenderViewHost(

host->render_view_host());

- if (devtools_cookie >= 0)

+ if (devtools_cookie != DevToolsAgentHost::EmptyCookie)

orphaned_dev_tools_[extension_id] = devtools_cookie;

}