Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4527)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_remote_apitest.cc

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Fixed thumbnail url generation, added a test Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_remote_apitest.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc b/chrome/browser/extensions/api/debugger/debugger_remote_apitest.cc
similarity index 56%
copy from chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc
copy to chrome/browser/extensions/api/debugger/debugger_remote_apitest.cc
index 753d3ff675538ff9f4bca50b95b689b17584c89b..6bffee1c87c386f61b152abf5802085df44920e1 100644
--- a/chrome/browser/extensions/api/debugger/debugger_extension_apitest.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_remote_apitest.cc
@@ -5,15 +5,16 @@
#include "base/command_line.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/common/chrome_switches.h"
+#include "content/public/common/content_switches.h"
-class ExtensionApiTestWithSwitch : public ExtensionApiTest {
+class ExtensionApiTestWithRemoteDebugger : public ExtensionApiTest {
public:
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
ExtensionApiTest::SetUpCommandLine(command_line);
- command_line->AppendSwitch(switches::kSilentDebuggerExtensionAPI);
+ command_line->AppendSwitchASCII(switches::kRemoteDebuggingPort, "9222");
}
};
-IN_PROC_BROWSER_TEST_F(ExtensionApiTestWithSwitch, ExtensionDebugger) {
- ASSERT_TRUE(RunExtensionTest("debugger_extension")) << message_;
+IN_PROC_BROWSER_TEST_F(ExtensionApiTestWithRemoteDebugger, RemoteDebugger) {
+ ASSERT_TRUE(RunExtensionTest("debugger_remote")) << message_;
}

Powered by Google App Engine
This is Rietveld 408576698