Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: content/browser/devtools/devtools_agent_host_impl.h

Issue 12319114: Extract debugger target enumeration into a separate class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@debugger
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_
6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 23 matching lines...) Expand all
34 void Detach(); 34 void Detach();
35 virtual void DispatchOnInspectorBackend(const std::string& message); 35 virtual void DispatchOnInspectorBackend(const std::string& message);
36 void InspectElement(int x, int y); 36 void InspectElement(int x, int y);
37 void AddMessageToConsole(ConsoleMessageLevel level, 37 void AddMessageToConsole(ConsoleMessageLevel level,
38 const std::string& message); 38 const std::string& message);
39 39
40 void set_close_listener(CloseListener* listener) { 40 void set_close_listener(CloseListener* listener) {
41 close_listener_ = listener; 41 close_listener_ = listener;
42 } 42 }
43 43
44 int id() { return id_; } 44 // DevToolsAgentHost implementation.
45 virtual std::string id() OVERRIDE { return id_; }
45 46
46 // DevToolsAgentHost implementation.
47 virtual RenderViewHost* GetRenderViewHost() OVERRIDE; 47 virtual RenderViewHost* GetRenderViewHost() OVERRIDE;
48 48
49 virtual std::string title() OVERRIDE;
50
51 virtual GURL url() OVERRIDE;
52
53 virtual GURL thumbnail_url() OVERRIDE;
54
55 virtual GURL favicon_url() OVERRIDE;
56
49 protected: 57 protected:
50 DevToolsAgentHostImpl(); 58 DevToolsAgentHostImpl();
51 virtual ~DevToolsAgentHostImpl() {} 59 virtual ~DevToolsAgentHostImpl() {}
52 60
53 virtual void SendMessageToAgent(IPC::Message* msg) = 0; 61 virtual void SendMessageToAgent(IPC::Message* msg) = 0;
54 virtual void NotifyClientAttaching() = 0; 62 virtual void NotifyClientAttaching() = 0;
55 virtual void NotifyClientDetaching() = 0; 63 virtual void NotifyClientDetaching() = 0;
56 64
57 void NotifyCloseListener(); 65 void NotifyCloseListener();
58 66
59 CloseListener* close_listener_; 67 CloseListener* close_listener_;
60 68
61 private: 69 private:
62 int id_; 70 const std::string id_;
63 }; 71 };
64 72
65 } // namespace content 73 } // namespace content
66 74
67 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_ 75 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698