Extract debugger target enumeration into a separate class

content/browser/devtools/devtools_agent_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_agent_host_impl.h"
 
 #include "base/basictypes.h"
+#include "base/stringprintf.h"
 #include "content/common/devtools_messages.h"
+#include "content/public/browser/devtools_manager.h"
 
 namespace content {
 
 namespace {
 static int g_next_agent_host_id = 0;
+
+static std::string GenerateId() {

[pfeldman, 2013/03/04 11:43:01]

Why?

[Vladislav Kaznacheev, 2013/03/04 14:30:03]

Inlined back.
On 2013/03/04 11:43:01, pfeldman wrote:

+  return base::StringPrintf("%d", ++g_next_agent_host_id);
+}
+
 }  // namespace
 
 DevToolsAgentHostImpl::DevToolsAgentHostImpl()
     : close_listener_(NULL),
-      id_(++g_next_agent_host_id) {
+      id_(GenerateId()) {
 }
 
 void DevToolsAgentHostImpl::Attach() {
   SendMessageToAgent(new DevToolsAgentMsg_Attach(MSG_ROUTING_NONE));
   NotifyClientAttaching();
 }
 
 void DevToolsAgentHostImpl::Reattach(const std::string& saved_agent_state) {
   SendMessageToAgent(new DevToolsAgentMsg_Reattach(
       MSG_ROUTING_NONE,
@@ skipping 22 matching lines @@
   SendMessageToAgent(new DevToolsAgentMsg_AddMessageToConsole(
       MSG_ROUTING_NONE,
       level,
       message));
 }
 
 RenderViewHost* DevToolsAgentHostImpl::GetRenderViewHost() {
   return NULL;
 }
 
+std::string DevToolsAgentHostImpl::title() {
+  return "";
+}
+
+GURL DevToolsAgentHostImpl::url() {
+  return GURL();
+}
+
+GURL DevToolsAgentHostImpl::thumbnail_url() {
+  return GURL();
+}
+
+GURL DevToolsAgentHostImpl::favicon_url() {
+  return GURL();
+}
+
 void DevToolsAgentHostImpl::NotifyCloseListener() {
   if (close_listener_) {
     scoped_refptr<DevToolsAgentHostImpl> protect(this);
     close_listener_->AgentHostClosing(this);
     close_listener_ = NULL;
   }
 }
 
 }  // namespace content