Extract debugger target enumeration into a separate class

content/browser/devtools/devtools_agent_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_
 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/common/console_message_level.h"
 
 namespace IPC {
 class Message;
 }
 
 namespace content {
 
+class NavigationEntry;
+
 // Describes interface for managing devtools agents from the browser process.
 class CONTENT_EXPORT DevToolsAgentHostImpl : public DevToolsAgentHost {
  public:
   class CONTENT_EXPORT CloseListener {
    public:
     virtual void AgentHostClosing(DevToolsAgentHostImpl*) = 0;
    protected:
     virtual ~CloseListener() {}
   };
 
   // Sends the message to the devtools agent hosted by this object.
   void Attach();
   void Reattach(const std::string& saved_agent_state);
   void Detach();
   virtual void DispatchOnInspectorBackend(const std::string& message);
   void InspectElement(int x, int y);
   void AddMessageToConsole(ConsoleMessageLevel level,
                            const std::string& message);
 
   void set_close_listener(CloseListener* listener) {
     close_listener_ = listener;
   }
 
-  int id() { return id_; }
+  // DevToolsAgentHost implementation.
+  virtual int id() OVERRIDE { return id_; }
 
-  // DevToolsAgentHost implementation.
+  virtual bool attached() OVERRIDE;
+
+  virtual std::string title() OVERRIDE;
+
+  virtual GURL url() OVERRIDE;
+
+  virtual GURL thumbnail_url() OVERRIDE;
+
+  virtual GURL favicon_url() OVERRIDE;
+
   virtual RenderViewHost* GetRenderViewHost() OVERRIDE;
 
  protected:
   DevToolsAgentHostImpl();
   virtual ~DevToolsAgentHostImpl() {}
 
   virtual void SendMessageToAgent(IPC::Message* msg) = 0;
   virtual void NotifyClientAttaching() = 0;
   virtual void NotifyClientDetaching() = 0;
 
   void NotifyCloseListener();
 
   CloseListener* close_listener_;
 
  private:
   int id_;
+
+  WebContents* GetWebContents();

[pfeldman, 2013/03/01 08:49:30]

These should only be in render_view_devtools_agent_host.*

[Vladislav Kaznacheev, 2013/03/01 12:58:35]

Done.

+  NavigationEntry* GetNavigationEntry();
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_AGENT_HOST_IMPL_H_