Issue 12319091: x11 desktop aura: Fix the cached bounds of the X window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12319091: x11 desktop aura: Fix the cached bounds of the X window. (Closed)

Created:
7 years, 10 months ago by sadrul

Modified:
7 years, 10 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

x11 desktop aura: Fix the cached bounds of the X window. The bounds in ConfigureNotify events are in the parent window's coordinate system, and the parent window may not be the X root window. So translate the origin of the window to the X root window's coordinate system first. This fixes the positioning of menus under some window managers. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184469

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	ui/views/widget/desktop_aura/desktop_root_window_host_linux.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

On 2013/02/25 02:40:16, sadrul wrote: cool. lgtm.

7 years, 10 months ago (2013-02-25 18:06:23 UTC) #2

sadrul

7 years, 10 months ago (2013-02-25 20:35:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r184469 (presubmit successful).

Expand Messages | Collapse Messages