Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 12319074: Merge 142571 (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 10 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 142571 > [chromium] Apply page scale to all WebInputEvent types > https://bugs.webkit.org/show_bug.cgi?id=109370 > > Reviewed by James Robinson. > > Previously we only adjusted a few common input event types by page > scale, but in fact almost every position and size in WebInputEvents > requires it. > > I also took the opportunity to change some WebGestureEvent members to > floats (which I checked causes no warnings in Chromium-side code with > GCC or Clang). > > New WebInputEventConversionTest: InputEventsScaling > > * public/WebInputEvent.h: > (WebKit::WebGestureEvent::WebGestureEvent): > * src/WebInputEventConversion.cpp: > (WebKit::widgetScaleFactor): > (WebKit): > (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder): > (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder): > (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder): > (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder): > (WebKit::updateWebMouseEventFromWebCoreMouseEvent): > (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): > (WebKit::addTouchPoints): > (WebKit::WebTouchEventBuilder::WebTouchEventBuilder): > (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): > * src/WebViewImpl.cpp: > (WebKit::WebViewImpl::handleGestureEvent): > (WebKit::WebViewImpl::hasTouchEventHandlersAt): > (WebKit::WebViewImpl::handleInputEvent): > * tests/WebInputEventConversionTest.cpp: > (WebCore::TEST): > (WebCore): > TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -71 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +189 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/public/WebInputEvent.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/WebKit/chromium/src/WebInputEventConversion.cpp View 16 chunks +58 lines, -35 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 3 chunks +11 lines, -22 lines 0 comments Download
M Source/WebKit/chromium/tests/WebInputEventConversionTest.cpp View 2 chunks +186 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:28:32 UTC) #1
aelias_OOO_until_Jul13
7 years, 10 months ago (2013-02-22 20:29:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r143774.

Powered by Google App Engine
This is Rietveld 408576698