Chromium Code Reviews
        
  DescriptionMerge 142571
> [chromium] Apply page scale to all WebInputEvent types
> https://bugs.webkit.org/show_bug.cgi?id=109370
> 
> Reviewed by James Robinson.
> 
> Previously we only adjusted a few common input event types by page
> scale, but in fact almost every position and size in WebInputEvents
> requires it.
> 
> I also took the opportunity to change some WebGestureEvent members to
> floats (which I checked causes no warnings in Chromium-side code with
> GCC or Clang).
> 
> New WebInputEventConversionTest: InputEventsScaling
> 
> * public/WebInputEvent.h:
> (WebKit::WebGestureEvent::WebGestureEvent):
> * src/WebInputEventConversion.cpp:
> (WebKit::widgetScaleFactor):
> (WebKit):
> (WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
> (WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
> (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
> (WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
> (WebKit::updateWebMouseEventFromWebCoreMouseEvent):
> (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
> (WebKit::addTouchPoints):
> (WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
> (WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
> * src/WebViewImpl.cpp:
> (WebKit::WebViewImpl::handleGestureEvent):
> (WebKit::WebViewImpl::hasTouchEventHandlersAt):
> (WebKit::WebViewImpl::handleInputEvent):
> * tests/WebInputEventConversionTest.cpp:
> (WebCore::TEST):
> (WebCore):
> 
TBR=aelias@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143774
   
  Patch Set 1 #
 Messages
    Total messages: 2 (0 generated)
     
  
  
       | 
    |||||||||||||||||||||||||||||||||||||||||||||||||||||||