Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4784)

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 12319073: Delete the extensions i18n message map when extension unload is received. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed "", windows should be happy now Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/dispatcher.cc
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 49695108dafa9634df4f63d46199086d7a449f4a..a0737a2e23de7cb5eebab3ad48dc0fe57b102693 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -16,6 +16,7 @@
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/common/extensions/manifest.h"
+#include "chrome/common/extensions/message_bundle.h"
#include "chrome/common/extensions/permissions/permission_set.h"
#include "chrome/common/url_constants.h"
#include "chrome/common/view_type.h"
@@ -515,6 +516,10 @@ void Dispatcher::OnUnloaded(const std::string& id) {
v8_context_set_.OnExtensionUnloaded(id);
+ // Invalidates the messages map for the extension in case the extension is
Yoyo Zhou 2013/03/08 22:17:50 By the way, the CL description is way too verbose
Patrick Riordan 2013/03/11 17:32:42 Done.
+ // reloaded with a new messages map.
+ EraseL10nMessagesMap(id);
+
// We don't do anything with existing platform-app stylesheets. They will
// stay resident, but the URL pattern corresponding to the unloaded
// extension's URL just won't match anything anymore.

Powered by Google App Engine
This is Rietveld 408576698