chrome/test/data/extensions/api_test/i18nUpdate/manifest.json - Issue 12319073: Delete the extensions i18n message map when extension unload is received.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/i18nUpdate/manifest.json

Issue 12319073: Delete the extensions i18n message map when extension unload is received. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed "", windows should be happy now Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/extensions/api_test/i18nUpdate/_locales/en/messages.json ('K') | « chrome/test/data/extensions/api_test/i18nUpdate/contentscript.js ('k') | chrome/test/data/extensions/api_test/i18nUpdate/messages2.json » ('j') | chrome/test/data/extensions/api_test/i18nUpdate/messages2.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name" : "i18n Message Test",
	Yoyo Zhou 2013/03/08 22:17:50 nit: no space before : nit: no space before : Patrick Riordan 2013/03/11 17:32:42 Done. Show quoted text On 2013/03/08 22:17:50, Yoyo Zhou wrote: > nit: no space before : Done.
	3 "version" : "1.0",

	4 "content_scripts" : [

	5 {

	6 "matches" : [ "<all_urls>" ],
	Yoyo Zhou 2013/03/08 22:17:50 nit: you don't need to buffer the contents of [] w nit: you don't need to buffer the contents of [] with spaces Patrick Riordan 2013/03/11 17:32:42 Done. Show quoted text On 2013/03/08 22:17:50, Yoyo Zhou wrote: > nit: you don't need to buffer the contents of [] with spaces Done.
	7 "js" : ["contentscript.js"]

	8 }

	9 ],

	10 "default_locale": "en",

	11 "manifest_version": 2

	12 }

OLD	NEW