Delete the extensions i18n message map when extension unload is received.

chrome/browser/extensions/content_script_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/file_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/permissions/permissions_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/test/base/ui_test_utils.h"
@@ skipping 152 matching lines @@
   PermissionsRequestFunction::SetAutoConfirmForTests(true);
   host_resolver()->AddRule("*.com", "127.0.0.1");
   ASSERT_TRUE(StartTestServer());
   ASSERT_TRUE(RunExtensionTest("content_scripts/permissions")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ContentScriptBypassPageCSP) {
   ASSERT_TRUE(StartTestServer());
   ASSERT_TRUE(RunExtensionTest("content_scripts/bypass_page_csp")) << message_;
 }
+
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ContentScriptUpdatei18nMessages)
+{

[Devlin, 2013/02/22 19:59:07]

Bracket on same line as function name.

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+  ASSERT_TRUE(StartTestServer());
+  // Create Extension whos messages.json file is to be updated.

[Devlin, 2013/02/22 19:59:07]

Make comments grammatically correct.
"Create _an_ Extension _whose_ message.json file will be updated."

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

[Devlin, 2013/02/26 05:57:12]

Still need to fix 'whos' to 'whose'. (I might also change "is to be" to "will
be", but that's personal preference, so it's up to you) :)

[Patrick Riordan, 2013/02/27 18:30:16]

Done.

+  base::FilePath extdir;

[Devlin, 2013/02/22 19:59:07]

As a rule, we try to avoid abbreviating variable names.  Some exceptions are
made for _very_ common ones (e.g., URL) and some slip through the cracks.  But
try to keep them full names; e.g. extension_dir.

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+  file_util::CreateNewTempDirectory("",&extdir);
+  file_util::CopyFile(
+      test_data_dir_.AppendASCII(
+          "content_scripts/message_reload1/manifest.json"),
+      extdir.AppendASCII("manifest.json"));
+  file_util::CopyFile(
+      test_data_dir_.AppendASCII(
+          "content_scripts/message_reload1/contentscript.js"),
+      extdir.AppendASCII("contentscript.js"));
+  file_util::CopyDirectory(
+      test_data_dir_.AppendASCII("content_scripts/message_reload1/_locales"),
+      extdir.AppendASCII("_locales"),
+      true);
+
+  const extensions::Extension*extension = LoadExtension(extdir);

[Devlin, 2013/02/22 19:59:07]

Space between Extension* and extension.

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+
+  ResultCatcher catcher;
+
+  //Test messages.json file is loaded and the i18n message is loaded.

[Devlin, 2013/02/22 19:59:07]

Space after comment beginning (i.e. "// Test...")
"Test _that the_ messages.json file...."

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+  ui_test_utils::NavigateToURL(
+      browser(), test_server()->GetURL("file/extensions/test_file.html"));
+
+  EXPECT_TRUE(catcher.GetNextResult());
+
+  string16 title;
+
+  ui_test_utils::GetCurrentTabTitle(browser(),&title);

[Devlin, 2013/02/22 19:59:07]

Space between arguments.

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+
+  EXPECT_EQ(std::string("FIRSTMESSAGE"), UTF16ToUTF8(title));
+
+  //Change messages.json file and reload extension.
+  file_util::CopyFile(
+      test_data_dir_.AppendASCII(
+          "content_scripts/message_reload1/messages.json"),
+      extdir.AppendASCII("_locales/en/messages.json"));
+
+  ReloadExtension(extension->id());
+
+  //Check i18n message is also changed.

[Devlin, 2013/02/22 19:59:07]

"Check _that the_ i18n message..."

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+  ui_test_utils::NavigateToURL(
+      browser(), test_server()->GetURL("file/extensions/test_file.html"));
+
+  EXPECT_TRUE(catcher.GetNextResult());
+
+  ui_test_utils::GetCurrentTabTitle(browser(),&title);
+
+  EXPECT_EQ(std::string("SECONDMESSAGE"), UTF16ToUTF8(title));

[Devlin, 2013/02/22 19:59:07]

There seems to be too many newlines between 204 and 230 - can some of these be
grouped logically?

[Patrick Riordan, 2013/02/26 05:05:20]

Done.

+}