Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 12319058: Revert 183977 (Closed)

Created:
7 years, 10 months ago by DaleCurtis
Modified:
7 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert 183977 > Audio indicator in each tab > > Basically a throbber animation that cycles over a number of > frames on a bitmap. Currently only 6 frames, which is too little > but good enough for testing. > > Note that the tab.cc logic should make it so that the audio indicator > is low on the priority. That is, if the tab is recording or broadcasting and > playing sounds that should show instead of the audio animation. > > BUG=3541 > TEST=see bug > > Review URL: https://chromiumcodereview.appspot.com/12328027 Broke Linux ChromiumOS Debug Clang: http://goo.gl/iOwf2 TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -70 lines) Patch
MM chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 5 chunks +17 lines, -50 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_renderer_data.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_renderer_data.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaleCurtis
7 years, 10 months ago (2013-02-22 02:23:58 UTC) #1
DaleCurtis
Committed patchset #1 manually as r183980.
7 years, 10 months ago (2013-02-22 02:24:07 UTC) #2
James Cook
7 years, 10 months ago (2013-02-22 16:14:50 UTC) #3
Message was sent while issue was closed.
On 2013/02/22 02:24:07, DaleCurtis wrote:
> Committed patchset #1 manually as r183980.

This probably collided with my rename of ShouldShowAudioIndicator to
IsPlayingAudio. A rebase/rename should fix it.

Powered by Google App Engine
This is Rietveld 408576698