Set the window frames to be non transparent while the user is cycling through workspaces

ash/wm/frame_painter_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/frame_painter.h"
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/wm/property_util.h"
@@ skipping 84 matching lines @@
     window_ = NULL;
     window->RemoveObserver(this);
   }
 
   aura::Window* window_;
   bool is_paint_scheduled_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowRepaintChecker);
 };
 
+// Modifies the values of kInactiveWindowOpacity, kActiveWindowOpacity, and
+// kSoloWindowOpacity for the lifetime of the class. This is useful so that
+// the constants each have different values.
+class ScopedOpacityConstantModifier {
+ public:
+  ScopedOpacityConstantModifier()
+      : initial_active_window_opacity_(
+            ash::FramePainter::kActiveWindowOpacity),
+        initial_inactive_window_opacity_(
+            ash::FramePainter::kInactiveWindowOpacity),
+        initial_solo_window_opacity_(ash::FramePainter::kSoloWindowOpacity) {
+    ash::FramePainter::kActiveWindowOpacity = 100;
+    ash::FramePainter::kInactiveWindowOpacity = 120;
+    ash::FramePainter::kSoloWindowOpacity = 140;
+  }
+  ~ScopedOpacityConstantModifier() {
+    ash::FramePainter::kActiveWindowOpacity = initial_active_window_opacity_;
+    ash::FramePainter::kInactiveWindowOpacity =
+        initial_inactive_window_opacity_;
+    ash::FramePainter::kSoloWindowOpacity = initial_solo_window_opacity_;
+  }
+
+ private:
+  int initial_active_window_opacity_;
+  int initial_inactive_window_opacity_;
+  int initial_solo_window_opacity_;
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedOpacityConstantModifier);
+};
+
 }  // namespace
 
 namespace ash {
 
 class FramePainterTest : public ash::test::AshTestBase {
  public:
   // Creates a test widget that owns its native widget.
   Widget* CreateTestWidget() {
     Widget* widget = new Widget;
     Widget::InitParams params;
@@ skipping 321 matching lines @@
 
 TEST_F(FramePainterTest, GetHeaderOpacity) {
   // Create a widget and a painter for it.
   scoped_ptr<Widget> w1(CreateTestWidget());
   FramePainter p1;
   ImageButton size1(NULL);
   ImageButton close1(NULL);
   p1.Init(w1.get(), NULL, &size1, &close1, FramePainter::SIZE_BUTTON_MAXIMIZES);
   w1->Show();
 
+  // Modify the values of the opacity constants so that they each have a
+  // different value.
+  ScopedOpacityConstantModifier opacity_constant_modifier;
+
   // Solo active window has solo window opacity.
   EXPECT_EQ(FramePainter::kSoloWindowOpacity,
             p1.GetHeaderOpacity(FramePainter::ACTIVE,
                                 IDR_AURA_WINDOW_HEADER_BASE_ACTIVE,
                                 NULL));
 
   // Create a second widget and painter.
   scoped_ptr<Widget> w2(CreateTestWidget());
   FramePainter p2;
   ImageButton size2(NULL);
@@ skipping 12 matching lines @@
             p2.GetHeaderOpacity(FramePainter::INACTIVE,
                                 IDR_AURA_WINDOW_HEADER_BASE_INACTIVE,
                                 NULL));
 
   // Custom overlay image is drawn completely opaque.
   gfx::ImageSkia custom_overlay;
   EXPECT_EQ(255,
             p1.GetHeaderOpacity(FramePainter::ACTIVE,
                                 IDR_AURA_WINDOW_HEADER_BASE_ACTIVE,
                                 &custom_overlay));
+
+  // Regular maximized window is fully transparent.

[James Cook, 2013/03/06 23:45:39]

Hooray for tests!

+  ash::wm::MaximizeWindow(w1->GetNativeWindow());
+  EXPECT_EQ(0,
+            p1.GetHeaderOpacity(FramePainter::ACTIVE,
+                                IDR_AURA_WINDOW_HEADER_BASE_ACTIVE,
+                                NULL));
+
+  // Windows with custom overlays are fully opaque when maximized.
+  EXPECT_EQ(255,
+            p1.GetHeaderOpacity(FramePainter::ACTIVE,
+                                IDR_AURA_WINDOW_HEADER_BASE_ACTIVE,
+                                &custom_overlay));
+
+  // The maximized window frame should take on the active/inactive opacity
+  // while the user is cycling through workspaces.
+  w1->GetNativeWindow()->GetRootWindow()->SetProperty(
+      ash::internal::kCyclingThroughWorkspacesKey, true);
+  EXPECT_EQ(FramePainter::kInactiveWindowOpacity,
+            p1.GetHeaderOpacity(FramePainter::INACTIVE,
+                                IDR_AURA_WINDOW_HEADER_BASE_ACTIVE,
+                                NULL));
 }
 
 // Test the hit test function with windows which are "partially maximized".
 TEST_F(FramePainterTest, HitTestSpecialMaximizedModes) {
   // Create a widget and a painter for it.
   scoped_ptr<Widget> w1(CreateResizableWidget());
   FramePainter p1;
   ImageButton size1(NULL);
   ImageButton close1(NULL);
   p1.Init(w1.get(), NULL, &size1, &close1, FramePainter::SIZE_BUTTON_MAXIMIZES);
@@ skipping 18 matching lines @@
   EXPECT_EQ(HTRIGHT,
             p1.NonClientHitTest(frame, gfx::Point(screen.width() / 2,
                                                   screen.height() / 2)));
   // A hit into the middle lower area should generate right - not bottom&right.
   EXPECT_EQ(HTRIGHT,
             p1.NonClientHitTest(frame, gfx::Point(screen.width() / 2,
                                                   screen.height() - 1)));
 }
 
 }  // namespace ash