Issue 12319039: Set the window frames to be non transparent while the user is cycling through workspaces

Issue 12319039: Set the window frames to be non transparent while the user is cycling through workspaces (Closed)

Created:
7 years, 10 months ago by pkotwicz

Modified:
7 years, 9 months ago

Reviewers:
James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set the window frames to be non transparent while the user is cycling through workspaces Bug=176025 Test=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186826

Patch Set 4 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -8 lines)			Patch
M	ash/wm/frame_painter.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/wm/frame_painter.cc	View	1 2 3	9 chunks	+43 lines, -8 lines	0 comments	Download
M	ash/wm/frame_painter_unittest.cc	View	1 2	3 chunks	+56 lines, -0 lines	0 comments	Download
M	ash/wm/window_properties.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/wm/window_properties.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_cycler_animator.cc	View	1 2	3 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

James, can you please take a look? We will probably want to vary whether we ...

7 years, 9 months ago (2013-03-06 23:24:02 UTC) #1

James Cook

https://codereview.chromium.org/12319039/diff/5001/ash/wm/frame_painter.cc File ash/wm/frame_painter.cc (right): https://codereview.chromium.org/12319039/diff/5001/ash/wm/frame_painter.cc#newcode665 ash/wm/frame_painter.cc:665: window->GetRootWindow()->AddObserver(this); Comment why this is necessary? I presume it's ...

7 years, 9 months ago (2013-03-06 23:45:39 UTC) #2

pkotwicz

7 years, 9 months ago (2013-03-07 00:47:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/12319039/11001

7 years, 9 months ago (2013-03-07 18:54:34 UTC) #5

Message was sent while issue was closed.

Change committed as 186826

Expand Messages | Collapse Messages