src/IceAssemblerX86Base.h - Issue 1231903002: Adds tests to the AssemblerX8632.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX86Base.h

Issue 1231903002: Adds tests to the AssemblerX8632. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceAssemblerX86Base.h

diff --git a/src/IceAssemblerX86Base.h b/src/IceAssemblerX86Base.h

index 8a556f080eeddff030f099ee7bf347cb8703322c..1db270ab20af84ff7d7f07670930fb124b280e37 100644

--- a/src/IceAssemblerX86Base.h

+++ b/src/IceAssemblerX86Base.h

@@ -332,10 +332,10 @@ public:

void setcc(typename Traits::Cond::BrCond condition,

const typename Traits::Address &address);

+ // All mov() overloads are tested.

void mov(Type Ty, typename Traits::GPRRegister dst, const Immediate &src);

void mov(Type Ty, typename Traits::GPRRegister dst,

typename Traits::GPRRegister src);

void mov(Type Ty, typename Traits::GPRRegister dst,

const typename Traits::Address &src);

void mov(Type Ty, const typename Traits::Address &dst,

@@ -824,6 +824,9 @@ public:

void hlt();

void ud2();

+ // j(Label) is fully tested.

+ // j(ConstantRelocatable) is not tested as the test can not easily create such

+ // an argument.

void j(typename Traits::Cond::BrCond condition, Label *label,

bool near = kFarJump);

void j(typename Traits::Cond::BrCond condition,

« no previous file with comments | « Makefile.standalone ('k') | unittest/IceAssemblerX8632Test.cpp » ('j') | no next file with comments »