Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1231893007: Debugger test updated to avoid setting breakpoints into random scripts. (Closed)

Created:
5 years, 5 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger test updated to avoid setting breakpoints into random scripts. Committed: https://crrev.com/edc61b26b412410c984e6c1bbc100d4cc3ace6c7 Cr-Commit-Position: refs/heads/master@{#29668}

Patch Set 1 : #

Patch Set 2 : Test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -44 lines) Patch
M test/mjsunit/debug-script-breakpoints.js View 1 2 chunks +54 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Igor Sheludko
PTAL
5 years, 5 months ago (2015-07-14 13:55:42 UTC) #3
Igor Sheludko
On 2015/07/14 13:55:42, Igor Sheludko wrote: > PTAL For some reason this updated test now ...
5 years, 5 months ago (2015-07-14 14:48:45 UTC) #5
Yang
On 2015/07/14 14:48:45, Igor Sheludko wrote: > On 2015/07/14 13:55:42, Igor Sheludko wrote: > > ...
5 years, 5 months ago (2015-07-14 14:53:19 UTC) #6
Igor Sheludko
On 2015/07/14 14:53:19, Yang wrote: > On 2015/07/14 14:48:45, Igor Sheludko wrote: > > On ...
5 years, 5 months ago (2015-07-14 16:30:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231893007/60001
5 years, 5 months ago (2015-07-15 07:33:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 5 months ago (2015-07-15 07:42:00 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 07:42:16 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edc61b26b412410c984e6c1bbc100d4cc3ace6c7
Cr-Commit-Position: refs/heads/master@{#29668}

Powered by Google App Engine
This is Rietveld 408576698