Issue 1231873007: Make changing themes work again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231873007: Make changing themes work again. (Closed)

Created:
5 years, 5 months ago by Hixie

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make changing themes work again. The fix is just to call syncFields() after calling setParent(), not before. This way makes more sense anyway. Also, check in some debug tools I used to track this down, and document some of the debug tools I used. Also, minor fixes to style. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d160fc34df26e82a700685cd1691ab475fb99973

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -14 lines)			Patch
M	sky/sdk/lib/rendering/README.md	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/widgets/README.md	View		2 chunks	+18 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/widgets/material.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	1	6 chunks	+30 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1231873007/diff/1/sky/sdk/lib/widgets/widget.dart File sky/sdk/lib/widgets/widget.dart (right): https://codereview.chromium.org/1231873007/diff/1/sky/sdk/lib/widgets/widget.dart#newcode1109 sky/sdk/lib/widgets/widget.dart:1109: App _app; :( https://codereview.chromium.org/1231873007/diff/1/sky/sdk/lib/widgets/widget.dart#newcode1113 sky/sdk/lib/widgets/widget.dart:1113: new AppContainer(app); Maybe ...

5 years, 5 months ago (2015-07-13 18:07:49 UTC) #2

Hixie

5 years, 5 months ago (2015-07-13 18:13:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d160fc34df26e82a700685cd1691ab475fb99973 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages