Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1231863018: Fix DSKey encoding. (Closed)

Created:
5 years, 5 months ago by iannucci
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M go/src/infra/gae/libs/gae/helper/serialize.go View 2 chunks +16 lines, -10 lines 0 comments Download
M go/src/infra/gae/libs/gae/helper/serialize_test.go View 1 2 chunks +27 lines, -3 lines 0 comments Download
M go/src/infra/gae/libs/gae/properties.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
iannucci
5 years, 5 months ago (2015-07-18 01:28:40 UTC) #1
dnj (Google)
lgtm
5 years, 5 months ago (2015-07-18 17:13:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231863018/20001
5 years, 5 months ago (2015-07-18 17:14:16 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-18 17:14:19 UTC) #7
dnj
On 2015/07/18 17:14:19, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 5 months ago (2015-07-18 17:16:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231863018/20001
5 years, 5 months ago (2015-07-19 18:20:13 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-19 18:22:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/ca9bcb2b4df7d32b8fde4b8ad4928...

Powered by Google App Engine
This is Rietveld 408576698