build/get_syzygy_binaries.py - Issue 1231863014: Don't launch sub-process through shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_syzygy_binaries.py

Issue 1231863014: Don't launch sub-process through shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/get_syzygy_binaries.py

diff --git a/build/get_syzygy_binaries.py b/build/get_syzygy_binaries.py

index 2a6469ffaa6de0f3184085d54c2c6626d246c153..1cab3fcf48dfd21f8c54e6492101f9d5df2e6300 100755

--- a/build/get_syzygy_binaries.py

+++ b/build/get_syzygy_binaries.py

@@ -256,7 +256,7 @@ def _GsUtil(*cmd):

timeout = 4 # Seconds.

while True:

_LOGGER.debug('Running %s', cmd)

- prog = subprocess.Popen(cmd, shell=True)

+ prog = subprocess.Popen(cmd, shell=False)

prog.communicate()

# Stop retrying on success.

« no previous file with comments | « no previous file | no next file » | no next file with comments »