Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1231853005: Revert of Sandbox: Make CreateRestrictedToken return a ScopedHandle. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sandbox: Make CreateRestrictedToken return a ScopedHandle. (patchset #2 id:20001 of https://codereview.chromium.org/1232963002/) Reason for revert: Broke the Win x64 debug build: 'GetRestrictedTokenHandle' : is not a member of 'sandbox::RestrictedToken' Original issue's description: > Sandbox: Make CreateRestrictedToken return a ScopedHandle. > > Removes raw handles from the API. > > BUG=426577 > > Committed: https://crrev.com/9808175ad322e8387366cdec088e65ccb934ceac > Cr-Commit-Position: refs/heads/master@{#339130} TBR=wfh@chromium.org,rvargas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=426577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -206 lines) Patch
M sandbox/win/src/restricted_token.h View 3 chunks +11 lines, -9 lines 0 comments Download
M sandbox/win/src/restricted_token.cc View 4 chunks +58 lines, -50 lines 0 comments Download
M sandbox/win/src/restricted_token_unittest.cc View 20 chunks +114 lines, -115 lines 0 comments Download
M sandbox/win/src/restricted_token_utils.h View 2 chunks +5 lines, -6 lines 0 comments Download
M sandbox/win/src/restricted_token_utils.cc View 3 chunks +25 lines, -14 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M sandbox/win/tools/finder/finder.h View 3 chunks +4 lines, -5 lines 0 comments Download
M sandbox/win/tools/finder/finder.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dcheng
Created Revert of Sandbox: Make CreateRestrictedToken return a ScopedHandle.
5 years, 5 months ago (2015-07-16 22:10:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231853005/1
5 years, 5 months ago (2015-07-16 22:10:51 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 22:13:53 UTC) #4
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698