Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1231803007: Add IsOSElCapitan() and other util functions. (Closed)

Created:
5 years, 5 months ago by shrike
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IsOSElCapitan() and other util functions. These functions mirror the IsOSYosemite(), etc. functions that already exist, and are needed for at least one future cl. BUG=510587 Committed: https://crrev.com/49c9add371f8e802e1788adfa0a2012e1e4d3064 Cr-Commit-Position: refs/heads/master@{#339085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M base/mac/mac_util.h View 3 chunks +17 lines, -0 lines 0 comments Download
M base/mac/mac_util.mm View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
5 years, 5 months ago (2015-07-16 16:45:10 UTC) #2
Nico
lgtm
5 years, 5 months ago (2015-07-16 16:52:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231803007/1
5 years, 5 months ago (2015-07-16 17:30:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 18:40:25 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 18:42:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49c9add371f8e802e1788adfa0a2012e1e4d3064
Cr-Commit-Position: refs/heads/master@{#339085}

Powered by Google App Engine
This is Rietveld 408576698