Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1231743004: [Background Sync] Remove single-parameter sync dispatch methods (Closed)

Created:
5 years, 5 months ago by iclelland
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Background Sync] Remove single-parameter sync dispatch methods This is part 3 of a three-part blink-chromium-blink dance: Part 1: https://codereview.chromium.org/1220223003/ Part 2: https://codereview.chromium.org/1230213004/ Part 3: [This one] BUG=482066 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199374

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 1 chunk +0 lines, -15 lines 0 comments Download
M public/web/WebServiceWorkerContextProxy.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
iclelland
5 years, 5 months ago (2015-07-22 16:41:05 UTC) #2
jkarlin
LGTM
5 years, 5 months ago (2015-07-22 17:01:21 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-23 09:21:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231743004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1231743004/20001
5 years, 5 months ago (2015-07-23 13:18:18 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 13:22:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199374

Powered by Google App Engine
This is Rietveld 408576698