Issue 1231733006: Revert of [Password Generation] Always save generated passwords

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1231733006: Revert of [Password Generation] Always save generated passwords (Closed)

Created:
5 years, 5 months ago by Garrett Casto

Modified:
5 years, 5 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of [Password Generation] Always save generated passwords (patchset #4 id:60001 of https://codereview.chromium.org/1213803006/) Reason for revert: Change causes generation to save passwords without a username in some cases. Original issue's description: > [Password Generation] Always save generated passwords > > TBR=estade@chromium.org > BUG=506307 > > Committed: https://crrev.com/01403f89096e52d043a473417a291f838b5de704 > Cr-Commit-Position: refs/heads/master@{#337648} TBR=vabr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=506307 Committed: https://crrev.com/0643660696cc62a332b3133de2708d112b6eb7b1 Cr-Commit-Position: refs/heads/master@{#338447}

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -160 lines)			Patch
M	chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/password_manager.cc	View	4 chunks	+9 lines, -22 lines	0 comments	Download
M	components/password_manager/core/browser/password_manager_unittest.cc	View	1 chunk	+0 lines, -137 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Garrett Casto

Created Revert of [Password Generation] Always save generated passwords

5 years, 5 months ago (2015-07-11 20:00:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231733006/1

5 years, 5 months ago (2015-07-11 20:00:55 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-11 20:02:19 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0643660696cc62a332b3133de2708d112b6eb7b1
Cr-Commit-Position: refs/heads/master@{#338447}

Expand Messages | Collapse Messages