Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1231723003: Switch Linux and CrOS to BoringSSL. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch Linux and CrOS to BoringSSL. This is a reland of https://codereview.chromium.org/1210073014/ with fixes to Linux expected shared library dependencies per http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/2784/steps/compile/logs/stdio On the dpkg side, the inferred minimum NSS version goes down because we no longer use PK11_SignWithSymKey. (The actual version is still overwritten in build.sh.) On the rpm side, we no longer use any function from libplc4.so (there used to be a PL_strdup call), so the linker prunes it. If this causes problems, please revert first and ask questions later. BUG=462040 TBR=rsleevi@chromium.org,thakis@chromium.org Committed: https://crrev.com/a4f7d7df73d96bd453b6c6a7f68f8de13f2b421b Cr-Commit-Position: refs/heads/master@{#338775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M build/common.gypi View 3 chunks +5 lines, -6 lines 0 comments Download
M build/config/crypto.gni View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/installer/linux/debian/expected_deps_ia32 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64 View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
davidben
mmoss for chrome/installer/*. See commit message for why dependencies changed. TBR rsleevi and thakis as ...
5 years, 5 months ago (2015-07-14 20:55:59 UTC) #2
davidben
+thestig for chrome/installer/linux since mmoss seems to be OOO.
5 years, 5 months ago (2015-07-14 21:00:17 UTC) #4
Lei Zhang
On 2015/07/14 21:00:17, David Benjamin wrote: > +thestig for chrome/installer/linux since mmoss seems to be ...
5 years, 5 months ago (2015-07-14 22:22:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231723003/1
5 years, 5 months ago (2015-07-14 22:30:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 23:56:14 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4f7d7df73d96bd453b6c6a7f68f8de13f2b421b Cr-Commit-Position: refs/heads/master@{#338775}
5 years, 5 months ago (2015-07-14 23:57:25 UTC) #9
Matt Giuca
Just looking at the sizes bot on chromium-rel-linux-64 [1], it seems this patch introduced a ...
5 years, 5 months ago (2015-07-21 04:36:51 UTC) #10
Ryan Sleevi
5 years, 5 months ago (2015-07-21 04:41:55 UTC) #11
Message was sent while issue was closed.
On 2015/07/21 04:36:51, Matt Giuca wrote:
> Just looking at the sizes bot on chromium-rel-linux-64 [1], it seems this
patch
> introduced a size regression of about 900 kB. Doesn't necessarily need a
revert;
> depends on whether this is preventable. http://crbug.com/512322.

Yeah, this is to be expected. We are now statically linked in BoringSSL, whereas
previously (well, technically, still) we dynamically link in the (system) NSS.

The size hit is expected, and we're still trimming down the BoringSSL bits (NSS
is ~4.5MB, the BoringSSL optimized crypto and paths are around 100K alone, w/o
any SSL bits)

Powered by Google App Engine
This is Rietveld 408576698