Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: tests/standalone/io/http_shutdown_test.dart

Issue 12317147: Implement addStream for HttpClientRequest/HttpResponse and propegate all write-errors from the sock… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/http_shutdown_test.dart
diff --git a/tests/standalone/io/http_shutdown_test.dart b/tests/standalone/io/http_shutdown_test.dart
index 60c320008f05b82fed762bdc62c9a7f52006002b..8c91797d584cb41d0b73cf0e61c9ce2e06adcf8f 100644
--- a/tests/standalone/io/http_shutdown_test.dart
+++ b/tests/standalone/io/http_shutdown_test.dart
@@ -53,6 +53,7 @@ void test2(int totalConnections, int outputStreamWrites) {
for (int i = 0; i < outputStreamWrites; i++) {
request.addString("Hello, world!");
}
+ request.done.catchError((_) {});
Søren Gjesse 2013/02/27 15:07:43 I think we should add default handling of this so
Anders Johnsen 2013/02/28 11:39:02 Yes, we need to decide on what should happen on th
return request.close();
})
.then((HttpClientResponse response) {
@@ -150,6 +151,7 @@ void test5(int totalConnections) {
(_) { },
onDone: () {
request.response.close();
+ request.response.done.catchError((e) {});
},
onError: (error) { });
},
@@ -166,6 +168,7 @@ void test5(int totalConnections) {
// TODO(sgjesse): Make this test work with
//request.response instead of request.close() return
//return request.response;
+ request.done.catchError((e) {});
return request.close();
})
.then((response) { })

Powered by Google App Engine
This is Rietveld 408576698