Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12317141: Added Isolate parameter to CodeStub::GetCode(). (Closed)

Created:
7 years, 9 months ago by Sven Panne
Modified:
7 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Added Isolate parameter to CodeStub::GetCode(). According to gprof, this was the #1 cause for TLS access during an Octane run. BUG=v8:2487 Committed: http://code.google.com/p/v8/source/detail?r=13756

Patch Set 1 #

Patch Set 2 : Fixed whitespace. Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -284 lines) Patch
M src/arm/code-stubs-arm.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 14 chunks +32 lines, -29 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 18 chunks +24 lines, -24 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/code-stubs.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/heap.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 17 chunks +23 lines, -23 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 10 chunks +13 lines, -12 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 14 chunks +31 lines, -30 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 18 chunks +24 lines, -24 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +16 lines, -15 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 18 chunks +24 lines, -24 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 9 months ago (2013-02-27 09:36:51 UTC) #1
Toon Verwaest
lgtm
7 years, 9 months ago (2013-02-27 12:21:02 UTC) #2
Sven Panne
7 years, 9 months ago (2013-02-27 12:33:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r13756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698