sdk/lib/async/future.dart - Issue 12317139: Make sure Future.forEach properly pipes exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/future.dart

Issue 12317139: Make sure Future.forEach properly pipes exceptions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/async/future.dart

diff --git a/sdk/lib/async/future.dart b/sdk/lib/async/future.dart

index 820ba0087d17181fbc5b5d92e6bfdad8b51a4906..b28b2c5c53ef2b1a6ffa46559084e6a812cf553b 100644

--- a/sdk/lib/async/future.dart

+++ b/sdk/lib/async/future.dart

@@ -190,7 +190,8 @@ abstract class Future<T> {

Iterator iterator = input.iterator;

void nextElement(_) {

if (iterator.moveNext()) {

- f(iterator.current).then(nextElement, onError: doneSignal._setError);

+ new Future.of(() => f(iterator.current))

+ .then(nextElement, onError: doneSignal._setError);

} else {

doneSignal._setValue(null);

}

« no previous file with comments | « no previous file | tests/lib/async/futures_test.dart » ('j') | no next file with comments »