Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: samples/swarm/swarm_ui_lib/view/PagedViews.dart

Issue 12317107: ceil/floor/truncate/round return integers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Some fixes from CL 11748016. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: samples/swarm/swarm_ui_lib/view/PagedViews.dart
diff --git a/samples/swarm/swarm_ui_lib/view/PagedViews.dart b/samples/swarm/swarm_ui_lib/view/PagedViews.dart
index 8a2ab01f5f5e69fb61ef10c3ce5e3b11c5518036..67667473595852526aa94c59022c90b7e22f1ac8 100644
--- a/samples/swarm/swarm_ui_lib/view/PagedViews.dart
+++ b/samples/swarm/swarm_ui_lib/view/PagedViews.dart
@@ -173,7 +173,7 @@ class PagedColumnView extends View {
if (value.endsWith('px')) {
value = value.substring(0, value.length - 2);
}
- return double.parse(value).round().toInt();
+ return double.parse(value).round();
}
/** Watch for resize and update page count. */
@@ -194,7 +194,7 @@ class PagedColumnView extends View {
window.setImmediate(() {
if (_container.scrollWidth > _container.offsetWidth) {
pageLength = (_container.scrollWidth / _computePageSize(_container))
- .ceil().toInt();
+ .ceil();
}
pageLength = Math.max(pageLength, 1);
@@ -219,7 +219,7 @@ class PagedColumnView extends View {
window.setImmediate(() {
num current = scroller.contentOffset.x;
int pageSize = _computePageSize(_container);
- pages.current.value = -(current / pageSize).round().toInt();
+ pages.current.value = -(current / pageSize).round();
});
}
@@ -247,7 +247,6 @@ class PagedColumnView extends View {
pageNumber = pageNumber.round();
}
}
- pageNumber = pageNumber.toInt();
num translate = -pageNumber * pageSize;
pages.current.value = pageNumber;
if (currentTarget != translate) {

Powered by Google App Engine
This is Rietveld 408576698